Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(session replay): add metadata to headers #598

Merged
merged 4 commits into from
Oct 13, 2023
Merged

feat(session replay): add metadata to headers #598

merged 4 commits into from
Oct 13, 2023

Conversation

jxiwang
Copy link

@jxiwang jxiwang commented Oct 6, 2023 •
edited
Loading

Summary

Adding sample rate, full url, and version number to header. When adding metadata to the body, the request throws 400 error. Also added version file update script to match sdk-bot.

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: Possible issues with SSR frameworks such as Next.js when accessing the window, but there is a check that should account for that in helper file under getCurrentUrl.

@jxiwang jxiwang requested a review from kwalker3690 October 6, 2023 16:43
@jxiwang jxiwang requested a review from kwalker3690 October 12, 2023 19:08
@jxiwang jxiwang merged commit ea6e54e into v1.x Oct 13, 2023
3 checks passed
@jxiwang jxiwang deleted the AMP-86222-Add-metadata-to-SDK branch October 13, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwalker3690 kwalker3690 kwalker3690 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jxiwang @kwalker3690