-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: proxy non-promised methods in browser-snippet #591
Merged
justin-fiedler
merged 4 commits into
main
from
AMP-85112-setUserId-is-not-queued-in-snippet
Sep 26, 2023
Merged
fix: proxy non-promised methods in browser-snippet #591
justin-fiedler
merged 4 commits into
main
from
AMP-85112-setUserId-is-not-queued-in-snippet
Sep 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justin-fiedler
requested review from
yuhao900914,
kevinpagtakhan and
Mercy811
September 22, 2023 22:18
This logic is added for the situation where the SDK is already loaded, but operations are called before init. |
yuhao900914
reviewed
Sep 25, 2023
yuhao900914
approved these changes
Sep 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
kevinpagtakhan
approved these changes
Sep 26, 2023
justin-fiedler
deleted the
AMP-85112-setUserId-is-not-queued-in-snippet
branch
September 26, 2023 20:06
justin-fiedler
added a commit
that referenced
this pull request
Sep 26, 2023
* fix: proxy non-promised methods in browser-snippet * fix: removed extra semicolon in browser-snippet template * fix: revert manual generated file changes * chore: undo manual changes to generated snippet
This was referenced Sep 26, 2023
justin-fiedler
added a commit
that referenced
this pull request
Sep 27, 2023
* fix: proxy non-promised methods in browser-snippet (#591) * fix: proxy non-promised methods in browser-snippet * fix: removed extra semicolon in browser-snippet template * fix: revert manual generated file changes * chore: undo manual changes to generated snippet * fix: update README.md for lerna to pickup package changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
AMP-85112
Non-promised functions are not being properly queued in the Browser snippet. There is existing logic in browser-client.ts, but I don't think that works in the proxy case.
I added new logic in the snippet to proxy non-promise methods.