Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update auto tracking plugin #589

Merged
merged 3 commits into from
Oct 6, 2023
Merged

Conversation

liuyang1520
Copy link
Contributor

@liuyang1520 liuyang1520 commented Sep 22, 2023

Summary

feat: update auto tracking plugin

  • Remove tagAllowList option to avoid confusion (if we want this, we can add in the future)
  • Add pageUrlAllowlist option
  • Add shouldTrackEventResolver option
  • Add dataAttributePrefix option
  • Add "arial label", "attributes", "selector" to the event property
  • Add "Element Parent Label" to the event property
  • Fork finder lib, reasons
    • Package install works, but it fails when building with the code, as it contains TS source file, seems to be an infamous bug of rollup, and the code has TS errors
    • Fork to local to make it more adjustable and testable
  • Remove property keys when the value is empty

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: No

@liuyang1520 liuyang1520 requested review from a team September 22, 2023 16:20
@liuyang1520
Copy link
Contributor Author

@justin-fiedler , re: meta tag info. I found the meta is at the page/site level. Do you think it is a little noisy to add for every event? If we want to add, maybe with a JSON event property like attributes?

@yuhao900914 yuhao900914 requested a review from a team September 22, 2023 17:05
@justin-fiedler
Copy link
Contributor

@justin-fiedler , re: meta tag info. I found the meta is at the page/site level. Do you think it is a little noisy to add for every event? If we want to add, maybe with a JSON event property like attributes?

Thanks, you can omit meta tags info for now. I will add it if needed for semantic autotrack.

@liuyang1520 liuyang1520 merged commit 1bfa2a2 into v1.x Oct 6, 2023
@liuyang1520 liuyang1520 deleted the update-auto-tracking-plugin branch October 6, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants