Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(session replay plugin): update plugin to use the sessionReplayProperties fn #588

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

kwalker3690
Copy link

Summary

We want to update all places we mention 'record' to mention 'replay' instead, so we will eventually deprecate getSessionRecordingProperties

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: no

Copy link

@jackson-amplitude jackson-amplitude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kwalker3690 kwalker3690 merged commit d1cd748 into v1.x Sep 21, 2023
@kwalker3690 kwalker3690 deleted the kwallach/update-properties-fn branch September 21, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants