fix(session replay): opt out should take effect immediately #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwalker3690
suggested changes
Sep 21, 2023
There was a problem hiding this comment.
Awesome this looks great! Do you mind adding some tests to cover both of these changes? I know the test coverage says 100% (which is interesting in and of itself...) but clearly we didn't have the test coverage for this logic already. Great catch on the identityStoreOptOut bug too!
…ddle of recording
kwalker3690
approved these changes
Sep 26, 2023
jxiwang
deleted the
AMP-83059-opt-out-should-take-effect-immediately
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix issue with session replay opt out not applying immediately. This change will immediately stop recordings and opt the user out of session replay.
Also fixed issue where identityStoreOptOut would default to this.config.optOut when identityStoreOptOut was false. This misses the case where optOut should be false and not defaulted to this.config.optOut which could be the previous optOut state.