feat(session replay): introduce standalone version of session replay #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwalker3690
requested review from
justin-fiedler,
kickerbear,
kevinpagtakhan and
jackson-amplitude
jackson-amplitude
approved these changes
Aug 23, 2023
There was a problem hiding this comment.
@kwalker3690 I think it would be good to see how this standalone version integrates with the plugin before releasing the standalone package, but ok releasing it if it makes the PRs cleaner.
|
@justin-fiedler yes! please see #555, also linked in the description. I think I have to merge this one first separately to be able to reference the built @amplitude/session-replay-browser from the plugin, the build currently fails because that package doesn't exist yet |
kevinpagtakhan
approved these changes
Aug 25, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a standalone version of the session replay SDK, that will also used by the existing plugin. There should be no functional changes in separating this to it's own package. This will allow us to support customers who want to use session replay who aren't instrumented through the browser SDK.
Please take a look at this closed PR which includes how the standalone SDK will be used in the plugin: #555. I will make a revision to incorporate the changes into the plugin once this PR has merged.
Checklist