feat(browser): set optOut config in analytics connector #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinpagtakhan
approved these changes
Aug 22, 2023
kwalker3690
pushed a commit
that referenced
this pull request
Aug 22, 2023
kwalker3690
pushed a commit
that referenced
this pull request
Aug 22, 2023
This reverts commit dd5408d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the v1 version of browser sdk to allow amplitude.setOptOut to set the opt out config in the analytics connector. The session replay SDK will need to be able to fetch the most up to date value for opt out at run time, which this allows.
Checklist