Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add example react-native plugin to get location, remove unused location-related logic from react-native #536

Merged
merged 2 commits into from
Aug 15, 2023
Merged

fix: add example react-native plugin to get location, remove unused location-related logic from react-native #536

merged 2 commits into from
Aug 15, 2023

Conversation

falconandy
Copy link
Contributor

@falconandy falconandy commented Aug 14, 2023 •
edited by justin-fiedler
Loading

Summary

https://amplitude.atlassian.net/browse/AMP-62860?focusedCommentId=204509

  1. Removes unused location-related logic from react-native (Android)
  2. Adds an example plugin to get location and set event properties.

Tested: Android/iOS emulators.

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: No

justin-fiedler
justin-fiedler approved these changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@justin-fiedler justin-fiedler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @falconandy!

@falconandy falconandy requested a review from yuhao900914 August 15, 2023 11:28
@justin-fiedler justin-fiedler linked an issue Aug 15, 2023 that may be closed by this pull request
react-native: country is missing from event #510
Closed
@justin-fiedler justin-fiedler merged commit 3fdfc53 into v1.x Aug 15, 2023
@justin-fiedler justin-fiedler deleted the AMP-62860-get-location-plugin-example branch August 15, 2023 16:19
@justin-fiedler justin-fiedler linked an issue Aug 15, 2023 that may be closed by this pull request
[bug] Version and location_lat and location_lng not being tracked #179
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justin-fiedler justin-fiedler justin-fiedler approved these changes

@Mercy811 Mercy811 Awaiting requested review from Mercy811

@yuhao900914 yuhao900914 Awaiting requested review from yuhao900914

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@falconandy @justin-fiedler @yuhao900914