feat(plugins): add teardown functionality to session replay plugin #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwalker3690
commented
Aug 7, 2023
kwalker3690
commented
Aug 7, 2023
kwalker3690
commented
Aug 7, 2023
kwalker3690
requested review from
jackson-amplitude,
kevinpagtakhan and
kickerbear
jackson-amplitude
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a teardown method to the session replay plugin, which is called when either
amplitude.remove()oramplitude.init()is called for a subsequent time. This method removes event listeners from the window, stops recording, and flushes the event queue, sending all remaining events.Checklist