fix: log error trace in catch blocks

amplitude · Oct 25, 2023 · bf36fe0 · bf36fe0
1 parent 1a2d6a4
commit bf36fe0
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/packages/analytics-core/src/core-client.ts b/packages/analytics-core/src/core-client.ts
@@ -127,8 +127,8 @@ export class AmplitudeCore implements CoreClient {
 
       return result;
     } catch (e) {
+      this.config.loggerProvider.error(e);
       const message = String(e);
-      this.config.loggerProvider.error(message);
       const result = buildResult(event, 0, message);
 
       return result;

diff --git a/packages/analytics-core/src/plugins/destination.ts b/packages/analytics-core/src/plugins/destination.ts
@@ -166,8 +166,8 @@ export class Destination implements DestinationPlugin {
       }
       this.handleResponse(res, list);
     } catch (e) {
+      this.config.loggerProvider.error(e);
       const errorMessage = getErrorMessage(e);
-      this.config.loggerProvider.error(errorMessage);
       this.fulfillRequest(list, 0, errorMessage);
     }
   }

diff --git a/packages/plugin-ga-events-forwarder-browser/src/ga-events-forwarder.ts b/packages/plugin-ga-events-forwarder-browser/src/ga-events-forwarder.ts
@@ -110,9 +110,9 @@ export const gaEventsForwarderPlugin = ({ measurementIds = [] }: Options = {}):
         }
       }
       return true;
-    } catch (error) {
+    } catch (e) {
       /* istanbul ignore next */
-      logger?.error(String(error));
+      logger?.error(e);
       return false;
     }
   };