Fix/nested splat syntax #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's possible to have a full splat with multiple get_attr or index elements after it. Such as foo[*][0].bar.baz[0] We also weren't handling regular splats correctly with multiple elements such as foo.*.bar.baz Update lark file and transformer to handle those cases
|
Thanks for the PR! Sorry for the long delay getting it reviewed. I committed a few additional changes because I realized there are other cases we aren't handling. Added tests for those cases which are now passing so will merge and release this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per Hashicorp's documentation,
[*]is the recommended way of using a splat operator.This PR is an attempt to parse nested splat operators.
As this is my first contribution and first time using lark, please review the change carefully.
The tests are passing, but I could be missing something.
You may find it easier to review this by looking at each commit.
Cheers
Addresses #81