feat(plugin): create MQTT plugin #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
overbit
suggested changes
Feb 9, 2024
There was a problem hiding this comment.
Generally looks good so good work @Shurtu-gal!
I've added some comments as, currently the generated code will fail in build and run successfully.
Once addressed we can quickly retest it (as I've tested throughly locally) and release.
plugins/broker-mqtt/src/tests/__snapshots__/createControllerFromTopics.spec.ts.snap
Outdated
Show resolved
Hide resolved
|
@overbit I have made the requested changes, regarding the build error, it is due to their being no topics as there are no message broker services enabled in the input.json for dsg. |
overbit
suggested changes
Feb 12, 2024
plugins/broker-mqtt/src/tests/__snapshots__/createControllerFromTopics.spec.ts.snap
Outdated
Show resolved
Hide resolved
plugins/broker-mqtt/src/tests/__snapshots__/createControllerFromTopics.spec.ts.snap
Show resolved
Hide resolved
plugins/broker-mqtt/src/tests/__snapshots__/createControllerFromTopics.spec.ts.snap
Outdated
Show resolved
Hide resolved
plugins/broker-mqtt/src/tests/__snapshots__/createControllerFromTopics.spec.ts.snap
Outdated
Show resolved
Hide resolved
plugins/broker-mqtt/src/tests/__snapshots__/createControllerFromTopics.spec.ts.snap
Outdated
Show resolved
Hide resolved
|
@overbit I have made the requested changes. |
overbit
previously approved these changes
Feb 14, 2024
overbit
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Add MQTT plugin
PR Checklist
npm builddoesn't throw any errornpm testdoesn't throw any errorIMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.