Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented 1Password Secret Manager Plugin #247

Closed

Conversation

happyPointr
Copy link

@happyPointr happyPointr commented Nov 11, 2023

Fixes: amplication/amplication#7017

PR Details

Implements Secret Manager Plugin using 1Password.

PR Checklist

  • npm build doesn't throw any error
  • npm test doesn't throw any error

@overbit
Copy link
Contributor

overbit commented Nov 15, 2023

@happyPointr as we are about to release new approach and plugin event for secrets manager, can you please update the plugin to support the new structure?
Check these PR #261 and #292 for better context

@overbit

This comment was marked as outdated.

This comment was marked as outdated.

@overbit overbit self-requested a review February 6, 2024 14:16
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@happyPointr have you seen my previous comment? #247 (comment)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@happyPointr any update?

@overbit overbit closed this Apr 15, 2024
@overbit
Copy link
Contributor

overbit commented Apr 15, 2024

Closed for inactivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

⭐ Plugin: Secret Manager - 1Password
2 participants