Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/e2e-tests-compose-approach #6

Merged
merged 3 commits into from
Apr 5, 2024
Merged

Fix/e2e-tests-compose-approach #6

merged 3 commits into from
Apr 5, 2024

Conversation

abrl91
Copy link

@abrl91 abrl91 commented Apr 5, 2024 •
edited
Loading

Part of: https://github.com/amplication/private-issues/issues/167

  • move the "docker-compose up" part from the workflow to the e2e test
  • fix an issue with the unique email field

@abrl91 abrl91 requested a review from overbit April 5, 2024 10:45
overbit
overbit approved these changes Apr 5, 2024
View reviewed changes
Copy link

@overbit overbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@abrl91 abrl91 merged commit 839fc90 into main Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overbit overbit overbit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abrl91 @overbit