Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use consistent key in split #113

Open
wants to merge 2 commits into
base: 2.x
Choose a base branch
from
Open

Conversation

danog
Copy link
Contributor

@danog danog commented Oct 16, 2024

Reliance on the key is useful in some conditions, and the non-monotonicity of the key caused a very nasty bug in our code.

@bwoebi
Copy link
Member

bwoebi commented Oct 16, 2024

You don't actually need $k, the main thing you need is replacing yield from by foreach. (which will then just use the auto-incrementing default).

@danog
Copy link
Contributor Author

danog commented Oct 16, 2024

True, but it's more explicit this way.

Copy link
Member

@kelunik kelunik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please cover this with a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants