fix java

amorynan · Oct 30, 2024 · eb31e80 · eb31e80
1 parent 33c87b8
commit eb31e80
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/be/src/vec/functions/function_ip.h b/be/src/vec/functions/function_ip.h
@@ -652,11 +652,9 @@ class FunctionIsIPAddressInRange : public IFunction {
     size_t get_number_of_arguments() const override { return 2; }
 
     DataTypePtr get_return_type_impl(const DataTypes& arguments) const override {
-        return std::make_shared<DataTypeUInt8>();
+        return make_nullable(std::make_shared<DataTypeUInt8>());
     }
 
-    bool use_default_implementation_for_nulls() const override { return false; }
-
     template <PrimitiveType PT, typename ColumnType>
     void execute_impl_with_ip(size_t input_rows_count, bool addr_const, bool cidr_const,
                               const ColumnString* str_cidr_column, const ColumnPtr addr_column,

diff --git a/.../java/org/apache/doris/nereids/trees/expressions/functions/scalar/IsIpAddressInRange.java b/.../java/org/apache/doris/nereids/trees/expressions/functions/scalar/IsIpAddressInRange.java
@@ -19,8 +19,8 @@
 
 import org.apache.doris.catalog.FunctionSignature;
 import org.apache.doris.nereids.trees.expressions.Expression;
-import org.apache.doris.nereids.trees.expressions.functions.AlwaysNotNullable;
 import org.apache.doris.nereids.trees.expressions.functions.ExplicitlyCastableSignature;
+import org.apache.doris.nereids.trees.expressions.functions.PropagateNullable;
 import org.apache.doris.nereids.trees.expressions.shape.BinaryExpression;
 import org.apache.doris.nereids.trees.expressions.visitor.ExpressionVisitor;
 import org.apache.doris.nereids.types.BooleanType;
@@ -38,7 +38,7 @@
  * scalar function `is_ip_address_in_range`
  */
 public class IsIpAddressInRange extends ScalarFunction
-        implements BinaryExpression, ExplicitlyCastableSignature, AlwaysNotNullable {
+        implements BinaryExpression, ExplicitlyCastableSignature, PropagateNullable {
 
     public static final List<FunctionSignature> SIGNATURES = ImmutableList.of(
             FunctionSignature.ret(BooleanType.INSTANCE).args(IPv4Type.INSTANCE, VarcharType.SYSTEM_DEFAULT),