Skip to content

Commit

Permalink
Revert "udp_session_filters: add HTTP capsule filter (envoyproxy#29569)…
Browse files Browse the repository at this point in the history
…" (envoyproxy#29714)

This reverts commit e953245.

This change broke the compile_time_options CI job.

Signed-off-by: Greg Greenway <[email protected]>
  • Loading branch information
ggreenway authored Sep 19, 2023
1 parent a660e81 commit de85ff2
Show file tree
Hide file tree
Showing 22 changed files with 1 addition and 778 deletions.
1 change: 0 additions & 1 deletion api/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,6 @@ proto_library(
"//envoy/extensions/filters/network/wasm/v3:pkg",
"//envoy/extensions/filters/network/zookeeper_proxy/v3:pkg",
"//envoy/extensions/filters/udp/dns_filter/v3:pkg",
"//envoy/extensions/filters/udp/udp_proxy/session/http_capsule/v3:pkg",
"//envoy/extensions/filters/udp/udp_proxy/v3:pkg",
"//envoy/extensions/formatter/cel/v3:pkg",
"//envoy/extensions/formatter/metadata/v3:pkg",
Expand Down

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,5 @@ message UdpProxyConfig {

// Optional session filters that will run for each UDP session.
// Only one of use_per_packet_load_balancing or session_filters can be used.
// [#extension-category: envoy.filters.udp.session]
repeated SessionFilter session_filters = 11;
}
1 change: 0 additions & 1 deletion api/versioning/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,6 @@ proto_library(
"//envoy/extensions/filters/network/wasm/v3:pkg",
"//envoy/extensions/filters/network/zookeeper_proxy/v3:pkg",
"//envoy/extensions/filters/udp/dns_filter/v3:pkg",
"//envoy/extensions/filters/udp/udp_proxy/session/http_capsule/v3:pkg",
"//envoy/extensions/filters/udp/udp_proxy/v3:pkg",
"//envoy/extensions/formatter/cel/v3:pkg",
"//envoy/extensions/formatter/metadata/v3:pkg",
Expand Down
4 changes: 0 additions & 4 deletions changelogs/current.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -256,10 +256,6 @@ new_features:
change: |
added :ref:` stats prefix option<envoy_v3_api_field_extensions.stat_sinks.open_telemetry.v3.SinkConfig.stats_prefix>`
to OTLP stats sink that enables adding a static prefix to all stats flushed by this sink.
- area: udp_proxy
change: |
added :ref:`http_capsule <envoy_v3_api_msg_extensions.filters.udp.udp_proxy.session.http_capsule.v3.FilterConfig>` UDP session filter
that can be used to encapsule or decapsulate UDP datagrams in HTTP, when used for UDP tunneling.
- area: tap
change: |
added :ref:`record_headers_received_time <envoy_v3_api_field_extensions.filters.http.tap.v3.Tap.record_headers_received_time>`
Expand Down
1 change: 0 additions & 1 deletion docs/root/api-v3/config/filter/filter.rst
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ Filters
listener/listener
network/network
udp/udp
udp/session
http/http
dubbo/dubbo
thrift/thrift
Expand Down
8 changes: 0 additions & 8 deletions docs/root/api-v3/config/filter/udp/session.rst

This file was deleted.

This file was deleted.

7 changes: 0 additions & 7 deletions docs/root/configuration/listeners/udp_filters/udp_proxy.rst
Original file line number Diff line number Diff line change
Expand Up @@ -89,13 +89,6 @@ upstream, similar to network filters.
Additionally, since :ref:`per packet load balancing <envoy_v3_api_field_extensions.filters.udp.udp_proxy.v3.UdpProxyConfig.use_per_packet_load_balancing>` require
choosing the upstream host for each received datagram, session filters can't be used when this option is enabled.

Envoy has the following builtin UDP session filters.

.. toctree::
:maxdepth: 2

session_filters/http_capsule

Example configuration
---------------------

Expand Down
6 changes: 0 additions & 6 deletions source/extensions/extensions_build_config.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -213,12 +213,6 @@ EXTENSIONS = {
"envoy.filters.udp.dns_filter": "//source/extensions/filters/udp/dns_filter:config",
"envoy.filters.udp_listener.udp_proxy": "//source/extensions/filters/udp/udp_proxy:config",

#
# UDP Session filters
#

"envoy.filters.udp.session.http_capsule": "//source/extensions/filters/udp/udp_proxy/session_filters/http_capsule:config",

#
# Resource monitors
#
Expand Down
7 changes: 0 additions & 7 deletions source/extensions/extensions_metadata.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -749,13 +749,6 @@ envoy.filters.udp_listener.udp_proxy:
status: stable
type_urls:
- envoy.extensions.filters.udp.udp_proxy.v3.UdpProxyConfig
envoy.filters.udp.session.http_capsule:
categories:
- envoy.filters.udp.session
security_posture: robust_to_untrusted_downstream
status: alpha
type_urls:
- envoy.extensions.filters.udp.udp_proxy.session.http_capsule.v3.FilterConfig
envoy.formatter.cel:
categories:
- envoy.formatter
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ class NamedUdpSessionFilterConfigFactory : public Envoy::Config::TypedFactory {
createFilterFactoryFromProto(const Protobuf::Message& config,
Server::Configuration::FactoryContext& context) PURE;

std::string category() const override { return "envoy.filters.udp.session"; }
std::string category() const override { return "envoy.udp.session_filters"; }
};

} // namespace SessionFilters
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Loading

0 comments on commit de85ff2

Please sign in to comment.