Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue (#359) #363

Merged
merged 1 commit into from
Apr 24, 2024
Merged

fix issue (#359) #363

merged 1 commit into from
Apr 24, 2024

Conversation

Sun-Woo-Kim
Copy link
Contributor

fix issue (#359)

};

if ([[config allKeys] containsObject:@"tagForUnderAgeConsent"]) {
NSNumber *tagC = [config valueForKey:@"tagForUnderAgeConsent"];
[[[GADMobileAds sharedInstance] requestConfiguration] tagForUnderAgeOfConsent:tagC.boolValue];
[[[GADMobileAds sharedInstance] requestConfiguration] setTagForChildDirectedTreatment:[NSNumber numberWithBool:tagC.boolValue]];
Copy link

@tcaish tcaish Apr 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there not a tagForUnderAgeConsent alternative, as well? Or does both have to be setTagForChildDirectedTreatment?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This did fix it though after running a build for iOS using Expo EAS.

Copy link

@tcaish tcaish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested by doing an expo prebuild with no errors and an EAS build with no errors. Good to go 🚀

@Sun-Woo-Kim
Copy link
Contributor Author

Hi, @ammarahm-ed Please review this. Thank you!

Copy link

@digibuilders digibuilders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed Expo Build Error, react-native-admob-native-ads 0.6.6. PLEASE MERGE

@ammarahm-ed ammarahm-ed merged commit c4cc493 into ammarahm-ed:master Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants