Ads repo fixbugs #239
Merged
Ads repo fixbugs #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* handle retry from repository (instead of ad view) * ad listener for android changed (for: click, impression, open, closed) * remove GADImageView from IOS (image will load with image tag in react-native)
…mob-native-ads into ads-repo-fixbugs
|
Is it possible that we keep using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes:
fix android bugs
fix ios bugs
case: the previous developer add RNGADImageView for this bug but after this update, the bug was fixed and no need to create RNGADImageView object anymore. on the other hand, if use RNGADImageView, it makes some bug in the project when the image load fast before the set ImageView size.
Tip: You can make two version of your repository one for before version 0.63.2 and one after version 0.63.2.
Note: Except remove image RNGADImageView, This update is required and necessary