-
-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Network Mediation][Android] Multiple things do not work #34
Comments
I do not understand the issue, kindly explain it more. How are you using FB audience, I have no experience with this right now |
@ammarahm-ed All children Views are empty/blank (on Android) apart from MediaView. This only happens on Android. On iOS devices it works fine. Is there any chance that this gets prioritized? |
onUnifiedNativeAdLoaded just does not get called most of the times on Android. |
I was trying to use
|
I too am in the same situation. |
@codervss what do you mean How you can help me, run |
I was reading again the docs and I noticed that "some Facebook native ad assets don't map one to one to Google native ad assets". Could this be the reason? @ammarahm-ed Yes, I am using FB mediation and as far as I understand, @codervss too |
@ammarahm-ed I am getting this from the logcat:
|
Okay, so it is unable to get information from video controller. Can you provide an example app with this? it would be helpful to fix this quickly |
I am not sure how I can do that. This doesn't happen with test ads. |
maybe use this: facebook ad testing |
I doesn't matter, facebook ad network does not expose its media assets like images etc. It loads them only into the MediaView so it is handled natively |
If you are unable to provide such an, I will probably look into it myself to see where it is happening and why but if you can, it would save a ton of time. |
Are the events such as onAdImpression and onAdClicked called or not? Because I think you have to manually log it back to the FacebookAdapter so it is logged on Facebook Audience Network too. |
And @codervss can you update us on whether you are getting the event sometimes and sometime no event? And usually when you get the event, is the content of the ad a video or image/slideshow etc?? |
Hello @ammarahm-ed and thank you so much for your interest. I have been trying to find a way to build an example app, but I don't understand how I can do so without publicly exposing my ads ids. The link that you provided is about adding test devices and run test ads |
Was this an issue on react-native-fb-ads too? But i think there, no impressions or clicks are logged inside the list on both android and ios. Do we need to log the impressions and clicks manually? Like have you checked if the If they are being logged then the issue is deeper inside the implementation on iOS. What about the usual ads from Admob network. Are their clicks being logged? |
Yes, on I am going to test your other questions now and revert back in a while. |
@ammarahm-ed The problem is with real ads on devices: Anyway, I believe this is a seperate issue that's why I have opened this. The problem here is that |
The views are blank always or sometimes? I mean is it so that sometimes the views load and sometimes they dont load at all? |
@ammarahm-ed Always on Android, never on iOS |
@ammarahm-ed |
How are you showing test ads in debug mode on android & iOS with facebook Mediation? |
I think I will need to setup facebook mediation to fix this properly |
I don't know exactly. I believe that is because if you set eCPM of Facebook quite high, it will get a higher priority and show ads from FB |
I have a problem, i cant claim an app on facebook monetization network, it says your business is prohibited. What if you can make a test property on facebook ads and put it in an example? can that work for you? and a test app on admob network which you can delete later? |
@ammarahm-ed I am really worried to publicly expose a property because I don't know if that could affect my other properties. Do you have any idea if that is true? |
You can send it to me privately if not here on github on my email, the example so I can fix the bug and push the code here with the fix. And i dont think it will effect other properties. You can delete or disable it once we have fixed the issue. |
@ammarahm-ed sent you an email |
I will look into this very soon!! |
@perrosnk do you have anydesk/teamviewer installed? I am unable to access my admob account for some reason. I can maybe fix it on your system if possible. |
Also I would suggest doing this: https://developers.facebook.com/docs/audience-network/android-network-security-config |
https://github.com/ammarahm-ed/react-native-admob-native-ads/tree/fb-audience-fix use this branch in your app. I think the issue with
|
Any updates on this @perrosnk |
@ammarahm-ed Sorry for the delay. Unfortunately it still is the same. It doesn't work |
Can you share the logcat report? @perrosnk . I have handled both errors above. Maybe now something else is causing the issue. |
|
Aha seems like one of the error is gone but the other one is still
persisting. can we do a session on Anydesk or Teamviewer? It will be easier
to fix this
…On Fri, Jun 19, 2020 at 9:41 AM perrosnk ***@***.***> wrote:
06-19 04:37:29.900 1029 3189 W Ads : App does not have the required permissions to get location
06-19 04:37:29.903 2705 3329 W Ads : Not retrying to fetch app settings
06-19 04:37:29.945 1029 3353 E Ads : Cannot determine request type. Is your ad unit id correct?
06-19 04:37:29.947 1029 3351 W Ads : App does not have the required permissions to get location
06-19 04:37:29.950 2705 3329 I Ads : Ad failed to load : 1
06-19 04:37:29.954 1029 1644 I Icing : IndexChimeraService.getServiceInterface callingPackage=com.google.android.gms componentName=null serviceId=36 [CONTEXT service_id=21 ]
06-19 04:37:29.966 1029 1644 I Icing : IndexChimeraService.getServiceInterface callingPackage=com.google.android.gms componentName=null serviceId=30 [CONTEXT service_id=21 ]
06-19 04:37:29.976 1029 2338 W Icing : No valid account for uploading user actions [CONTEXT service_id=21 ]
06-19 04:37:29.981 1029 3349 I Ads : SDK version: afma-sdk-a-v201604999.201604000.1
06-19 04:37:30.001 1029 2338 I Icing : Usage reports ok 1, Failed Usage reports 0, indexed 0, rejected 0 [CONTEXT service_id=21 ]
06-19 04:37:30.004 1029 2338 W Icing : No valid account for uploading user actions [CONTEXT service_id=21 ]
06-19 04:37:30.013 1029 2338 I Icing : Usage reports ok 0, Failed Usage reports 0, indexed 0, rejected 0 [CONTEXT service_id=21 ]
06-19 04:37:30.170 365 551 D Sensors : batch handle 1, but there is no batch sensor in genymotion
06-19 04:37:30.372 365 365 D Sensors : batch handle 1, but there is no batch sensor in genymotion
06-19 04:37:30.836 2705 2705 D FacebookAdapter: onMediaDownloaded
06-19 04:37:30.869 2705 2705 E Ads : Remote exception getting video controller aspect ratio.
06-19 04:37:30.869 2705 2705 E Ads : android.os.RemoteException
06-19 04:37:30.869 2705 2705 E Ads : at ***@***.***@21829003.311174395.311174395:0)
06-19 04:37:30.869 2705 2705 E Ads : at ***@***.***@21829003.311174395.311174395:33)
06-19 04:37:30.869 2705 2705 E Ads : at ***@***.***@21829003.311174395.311174395:4)
06-19 04:37:30.869 2705 2705 E Ads : at android.os.Binder.transact(Binder.java:604)
06-19 04:37:30.869 2705 2705 E Ads : at com.google.android.gms.internal.ads.zzgu.transactAndReadException(com.google.android.gms:play-services-ads-base@@19.2.0:10)
06-19 04:37:30.869 2705 2705 E Ads : at com.google.android.gms.internal.ads.zzadq.getAspectRatio(com.google.android.gms:play-services-ads-lite@@19.2.0:4)
06-19 04:37:30.869 2705 2705 E Ads : at com.google.android.gms.internal.ads.zzzc.getAspectRatio(com.google.android.gms:play-services-ads-lite@@19.2.0:5)
06-19 04:37:30.869 2705 2705 E Ads : at com.ammarahmed.rnadmob.nativeads.RNNativeAdWrapper.setNativeAdToJS(RNNativeAdWrapper.java:174)
06-19 04:37:30.869 2705 2705 E Ads : at com.ammarahmed.rnadmob.nativeads.RNNativeAdWrapper.access$100(RNNativeAdWrapper.java:26)
06-19 04:37:30.869 2705 2705 E Ads : at com.ammarahmed.rnadmob.nativeads.RNNativeAdWrapper$3.onUnifiedNativeAdLoaded(RNNativeAdWrapper.java:120)
06-19 04:37:30.869 2705 2705 E Ads : at com.google.android.gms.internal.ads.zzagh.zza(com.google.android.gms:play-services-ads-lite@@19.2.0:6)
06-19 04:37:30.869 2705 2705 E Ads : at com.google.android.gms.internal.ads.zzafl.zza(com.google.android.gms:play-services-ads-lite@@19.2.0:18)
06-19 04:37:30.869 2705 2705 E Ads : at com.google.android.gms.internal.ads.zzgt.onTransact(com.google.android.gms:play-services-ads-base@@19.2.0:13)
06-19 04:37:30.869 2705 2705 E Ads : at android.os.Binder.transact(Binder.java:604)
06-19 04:37:30.869 2705 2705 E Ads : at ***@***.***@21829003.311174395.311174395:2)
06-19 04:37:30.869 2705 2705 E Ads : at ***@***.***@21829003.311174395.311174395:0)
06-19 04:37:30.869 2705 2705 E Ads : at com.google.android.gms.ads.nonagon.ad.nativead.ac.run(Unknown Source:6)
06-19 04:37:30.869 2705 2705 E Ads : at android.os.Handler.handleCallback(Handler.java:789)
06-19 04:37:30.869 2705 2705 E Ads : at android.os.Handler.dispatchMessage(Handler.java:98)
06-19 04:37:30.869 2705 2705 E Ads : at ***@***.***@21829003.311174395.311174395:0)
06-19 04:37:30.869 2705 2705 E Ads : at ***@***.***@21829003.311174395.311174395:1)
06-19 04:37:30.869 2705 2705 E Ads : at ***@***.***@21829003.311174395.311174395:0)
06-19 04:37:30.869 2705 2705 E Ads : at android.os.Looper.loop(Looper.java:164)
06-19 04:37:30.869 2705 2705 E Ads : at android.app.ActivityThread.main(ActivityThread.java:6541)
06-19 04:37:30.869 2705 2705 E Ads : at java.lang.reflect.Method.invoke(Native Method)
06-19 04:37:30.869 2705 2705 E Ads : at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:240)
06-19 04:37:30.869 2705 2705 E Ads : at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:767)
06-19 04:37:31.052 2705 2719 I zygote : Background concurrent copying GC freed 194557(9MB) AllocSpace objects, 43(1480KB) LOS objects, 49% free, 10MB/20MB, paused 2.931ms total 190.403ms
06-19 04:37:32.122 2705 2705 D DynamitePackage: Instantiating com.google.android.gms.ads.ChimeraNativeAdViewDelegateCreatorImpl
06-19 04:37:32.128 2705 2705 D DynamitePackage: Instantiating com.google.android.gms.ads.ChimeraAdLoaderBuilderCreatorImpl
06-19 04:37:32.130 2705 2705 I Ads : Use RequestConfiguration.Builder().setTestDeviceIds(Arrays.asList("28C844774F17E19AD06B5DCA7AEDD33C") to get test ads on this device.
06-19 04:37:32.156 2705 2705 D DynamitePackage: Instantiating com.google.android.gms.ads.ChimeraAdLoaderBuilderCreatorImpl
06-19 04:37:32.159 2705 2705 I Ads : Use RequestConfiguration.Builder().setTestDeviceIds(Arrays.asList("28C844774F17E19AD06B5DCA7AEDD33C") to get test ads on this device.
06-19 04:37:32.164 2705 3308 W Ads : Not retrying to fetch app settings
06-19 04:37:32.180 1029 3349 W Ads : App does not have the required permissions to get location
06-19 04:37:32.215 1029 3349 E Ads : Cannot determine request type. Is your ad unit id correct?
06-19 04:37:32.227 2705 3326 W Ads : Not retrying to fetch app settings
06-19 04:37:32.227 2705 3309 I Ads : Ad failed to load : 1
06-19 04:37:32.262 1029 3349 W Ads : App does not have the required permissions to get location
06-19 04:37:32.294 1029 3351 I Ads : SDK version: afma-sdk-a-v201604999.201604000.1
06-19 04:37:32.809 365 365 D Sensors : batch handle 1, but there is no batch sensor in genymotion
06-19 04:37:32.866 2705 2770 W OkHttpClient: A connection to https://googleads.g.doubleclick.net/ was leaked. Did you forget to close a response body?
06-19 04:37:32.910 2705 2705 D FacebookAdapter: onMediaDownloaded
06-19 04:37:32.920 2705 2705 E Ads : Remote exception getting video controller aspect ratio.
06-19 04:37:32.920 2705 2705 E Ads : android.os.RemoteException
06-19 04:37:32.920 2705 2705 E Ads : at ***@***.***@21829003.311174395.311174395:0)
06-19 04:37:32.920 2705 2705 E Ads : at ***@***.***@21829003.311174395.311174395:33)
06-19 04:37:32.920 2705 2705 E Ads : at ***@***.***@21829003.311174395.311174395:4)
06-19 04:37:32.920 2705 2705 E Ads : at android.os.Binder.transact(Binder.java:604)
06-19 04:37:32.920 2705 2705 E Ads : at com.google.android.gms.internal.ads.zzgu.transactAndReadException(com.google.android.gms:play-services-ads-base@@19.2.0:10)
06-19 04:37:32.920 2705 2705 E Ads : at com.google.android.gms.internal.ads.zzadq.getAspectRatio(com.google.android.gms:play-services-ads-lite@@19.2.0:4)
06-19 04:37:32.920 2705 2705 E Ads : at com.google.android.gms.internal.ads.zzzc.getAspectRatio(com.google.android.gms:play-services-ads-lite@@19.2.0:5)
06-19 04:37:32.920 2705 2705 E Ads : at com.ammarahmed.rnadmob.nativeads.RNNativeAdWrapper.setNativeAdToJS(RNNativeAdWrapper.java:174)
06-19 04:37:32.920 2705 2705 E Ads : at com.ammarahmed.rnadmob.nativeads.RNNativeAdWrapper.access$100(RNNativeAdWrapper.java:26)
06-19 04:37:32.920 2705 2705 E Ads : at com.ammarahmed.rnadmob.nativeads.RNNativeAdWrapper$3.onUnifiedNativeAdLoaded(RNNativeAdWrapper.java:120)
06-19 04:37:32.920 2705 2705 E Ads : at com.google.android.gms.internal.ads.zzagh.zza(com.google.android.gms:play-services-ads-lite@@19.2.0:6)
06-19 04:37:32.920 2705 2705 E Ads : at com.google.android.gms.internal.ads.zzafl.zza(com.google.android.gms:play-services-ads-lite@@19.2.0:18)
06-19 04:37:32.920 2705 2705 E Ads : at com.google.android.gms.internal.ads.zzgt.onTransact(com.google.android.gms:play-services-ads-base@@19.2.0:13)
06-19 04:37:32.920 2705 2705 E Ads : at android.os.Binder.transact(Binder.java:604)
06-19 04:37:32.920 2705 2705 E Ads : at ***@***.***@21829003.311174395.311174395:2)
06-19 04:37:32.920 2705 2705 E Ads : at ***@***.***@21829003.311174395.311174395:0)
06-19 04:37:32.920 2705 2705 E Ads : at com.google.android.gms.ads.nonagon.ad.nativead.ac.run(Unknown Source:6)
06-19 04:37:32.920 2705 2705 E Ads : at android.os.Handler.handleCallback(Handler.java:789)
06-19 04:37:32.920 2705 2705 E Ads : at android.os.Handler.dispatchMessage(Handler.java:98)
06-19 04:37:32.920 2705 2705 E Ads : at ***@***.***@21829003.311174395.311174395:0)
06-19 04:37:32.920 2705 2705 E Ads : at ***@***.***@21829003.311174395.311174395:1)
06-19 04:37:32.920 2705 2705 E Ads : at ***@***.***@21829003.311174395.311174395:0)
06-19 04:37:32.920 2705 2705 E Ads : at android.os.Looper.loop(Looper.java:164)
06-19 04:37:32.920 2705 2705 E Ads : at android.app.ActivityThread.main(ActivityThread.java:6541)
06-19 04:37:32.920 2705 2705 E Ads : at java.lang.reflect.Method.invoke(Native Method)
06-19 04:37:32.920 2705 2705 E Ads : at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:240)
06-19 04:37:32.920 2705 2705 E Ads : at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:767)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#34 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJTACUVXZXIWT57ZCNQX6BTRXLUAVANCNFSM4NWTTXPA>
.
|
@perrosnk update me on this when you are free. Its a small bug, wont take much time hopefully |
@ammarahm-ed I have replied to your email |
@perrosnk just checked and replied back |
We are using everything default and onUnifiedNativeAdLoaded is never called on some android devices and on some others it gets called. We are testing with the test ads. |
@prasanthsd @perrosnk Can you test the
|
@ammarahm-ed No, it's not working. Same issues EDIT: I am sending a link to compare the code that you published with the one saved one my mac https://www.diffchecker.com/6iChi9pq |
@perrosnk maybe we need to sit again on anydesk to fix this properly. Actually some part of the code was disabled, we need it for Admob ads, i think it is throwing exception there. |
Release a new version |
I have the same issue -
|
Fixed on master |
When using FB audience,
onUnifiedNativeAdLoaded
is never called. No children Views work apart from MediaView.The issue appear on Android. On iOS everything works fine. Tested on both simulator and real devices.
The text was updated successfully, but these errors were encountered: