Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from atlassian:main #79

Merged
merged 3 commits into from
Sep 8, 2023

Conversation

pull[bot]
Copy link

@pull pull bot commented Sep 6, 2023

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

* - WIP

* - WIP

* - Increasing the timeout for playwright

* - Fixing the annoying testids

* - Adding timeouts

* - Increasing timeout to check

* - Reverting

* - WIP

* - Skipping other builds for now

* - Skipping other builds for quick testing, will add it back later

* - WIP

* - WIP

* - WIP

* - WIP

* - Testing

* - Testing

* - Testing

* - Finalizing

* - Correcting the project key instead of id when creating projects

* - Correcting the project key instead of id when creating projects
@restack-app
Copy link

restack-app bot commented Sep 6, 2023

No applications have been configured for previews targeting branch: main. To do so go to restack console and configure your applications for previews.

@commit-lint
Copy link

commit-lint bot commented Sep 6, 2023

None

Contributors

krazziekay, bgvozdev, Harminder84

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@pr-code-reviewer
Copy link

pr-code-reviewer bot commented Sep 6, 2023

👋 Hi there!

  1. In the package.json file, the change "start:no-spa": "run-p start:main start:worker" should be improved by adding "yarn prestart && " before the existing command to ensure that the necessary setup tasks are performed before starting the application.

  2. In the src/interfaces/common.ts file, the change should be completed to include the missing part of the code after "Ba", ensuring the code is valid and complete.

  3. Further improvements or optimizations may require a more detailed analysis of the code and its context beyond the provided diff.


Automatically generated with the help of gpt-3.5-turbo.
Feedback? Please don't hesitate to drop me an email at [email protected].

@instapr
Copy link

instapr bot commented Sep 6, 2023

The PR looks good overall. I have left a couple of inline comments for minor improvements. Once those are addressed, we should be good to merge this. Nice job!

@pull pull bot added the ⤵️ pull label Sep 6, 2023
@pr-explainer-bot
Copy link

Pull Request Report

Hey there! Here's a report on the changes made in the pull request:

Changes

  1. In package.json, the start:no-spa script was modified to include a yarn prestart command before running start:main and start:worker.

Suggestions

No suggestions were made in this pull request.

Bugs

  1. In constants.ts, there was a bug where the PROJECT_ID environment variable was being checked instead of PROJECT_KEY in the projectId function. This bug was fixed by updating the variable name to PROJECT_KEY.

Improvements

  1. In jira.ts, the project key was being set after a delay of 2000 milliseconds. This delay was added to ensure that the project key is set before it is used. The project key is now retrieved from the page using the getByTestId function and stored in the PROJECT_KEY environment variable.

Rating

I would rate the code in this pull request as follows:

  • Readability: 8/10
  • Performance: 9/10
  • Security: 9/10

That's it for the pull request report! Let me know if you need any further information.

@sonarcloud
Copy link

sonarcloud bot commented Sep 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ammar-ahmed-butt ammar-ahmed-butt merged commit 267fb2a into ammar-knowledge:main Sep 8, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants