-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] main from atlassian:main #77
Conversation
* display list of repos states * added pagination for repo list * removed unusd handlebar helper * minor tidies on order and view hbs * Updated pagination, adding filtering and searching * update message * updated UI as per specs * fix unit testing * Fixed unit testing * NONE: outlined TODOs and fixed some dodgy scenarios * NONE: fix in_progress logic * ARC-968: fix navigation * ARC-968: fix layout * ARC-968: filter by fullName * ARC-968: fix tests, add placeholders for the new tests * ARC-968: add some tests * ARC-968: fix test * ARC-968: tests * ARC-968: uncomment the FF --------- Co-authored-by: Josh Kay <[email protected]> Co-authored-by: joshkay10 <[email protected]> Co-authored-by: Rachelle Rathbone <[email protected]> Co-authored-by: Harminder84 <[email protected]> Co-authored-by: Harminder <[email protected]> Co-authored-by: Gary Xue <[email protected]>
No applications have been configured for previews targeting branch: main. To do so go to restack console and configure your applications for previews. |
ContributorsCommit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
👋 Hi there!Everything looks good!
|
The link to the image seems to be broken. Please update it. Thanks! |
Pull Request ReviewHey there! 👋 I've summarized the previous results for you. Here's a markdown document to help you write your pull request review: Changes
Suggestions
Bugs
Improvements
const mapFilterSyncStatusToQueryCondition = (filterStatusField: string | undefined) => {
if (!filterStatusField || filterStatusField === 'all') {
return {};
}
if (filterStatusField === 'pending') {
return {
[Op.or]: [
{ branchStatus: 'pending' },
{ branchStatus: null },
{ commitStatus: 'pending' },
{ commitStatus: null },
{ pullStatus: 'pending' },
{ pullStatus: null },
{ buildStatus: 'pending' },
{ buildStatus: null },
{ deploymentStatus: 'pending' },
{ deploymentStatus: null }
]
};
} else if (filterStatusField == 'failed') {
return {
[Op.or]: [
{ branchStatus: ... RatingI cannot rate the code as I am a bot and do not have the capability to evaluate code quality. 🤖 Remember to consider the commit history and the co-authors mentioned below. Good luck with your pull request! 🎉 Co-authored-by: Josh Kay [email protected] P.S. If you're on a premium plan, you can analyze bigger pull requests. Just something to keep in mind! 😉 |
Kudos, SonarCloud Quality Gate passed! |
@@ -37,6 +38,8 @@ | |||
|
|||
JiraRouter.get("/", csrfMiddleware, jiraSymmetricJwtMiddleware, jiraAdminPermissionsMiddleware, JiraGet); | |||
|
|||
JiraRouter.get("/subscription/:subscriptionId/repos", csrfMiddleware, jiraSymmetricJwtMiddleware, jiraAdminPermissionsMiddleware, JiraConnectedReposGet); |
Check failure
Code scanning / CodeQL
Missing rate limiting High
See Commits and Changes for more details.
Created by pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )