Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from atlassian:main #77

Merged
merged 2 commits into from
Sep 2, 2023

Conversation

pull[bot]
Copy link

@pull pull bot commented Sep 1, 2023

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

* display list of repos states

* added pagination for repo list

* removed unusd handlebar helper

* minor tidies on order and view hbs

* Updated pagination, adding filtering and searching

* update message

* updated UI as per specs

* fix unit testing

* Fixed unit testing

* NONE: outlined TODOs and fixed some dodgy scenarios

* NONE: fix in_progress logic

* ARC-968: fix navigation

* ARC-968: fix layout

* ARC-968: filter by fullName

* ARC-968: fix tests, add placeholders for the new tests

* ARC-968: add some tests

* ARC-968: fix test

* ARC-968: tests

* ARC-968: uncomment the FF

---------

Co-authored-by: Josh Kay <[email protected]>
Co-authored-by: joshkay10 <[email protected]>
Co-authored-by: Rachelle Rathbone <[email protected]>
Co-authored-by: Harminder84 <[email protected]>
Co-authored-by: Harminder <[email protected]>
Co-authored-by: Gary Xue <[email protected]>
@restack-app
Copy link

restack-app bot commented Sep 1, 2023

No applications have been configured for previews targeting branch: main. To do so go to restack console and configure your applications for previews.

@commit-lint
Copy link

commit-lint bot commented Sep 1, 2023

Contributors

bgvozdev, gxueatlassian

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@pr-code-reviewer
Copy link

pr-code-reviewer bot commented Sep 1, 2023

👋 Hi there!

Everything looks good!


Automatically generated with the help of gpt-3.5-turbo.
Feedback? Please don't hesitate to drop me an email at [email protected].

@instapr
Copy link

instapr bot commented Sep 1, 2023

The link to the image seems to be broken. Please update it. Thanks!

@pr-explainer-bot
Copy link

Pull Request Review

Hey there! 👋 I've summarized the previous results for you. Here's a markdown document to help you write your pull request review:

Changes

  1. Added a new feature flag ENABLE_CONNECTED_REPOS_VIEW in the feature-flags.ts file at line 27. 🚩

Suggestions

  1. In the reposyncstate.ts file at line 182, the countSubscriptionRepos function is made static. Consider if it should be static or not. 🤔
  2. In the subscription.ts file at line 48, the gitHubAppId property is defined as number | undefined. Consider if it should have a default value or not. 🤔

Bugs

  1. In the jira-atlassian-connect-get.ts file at line 221, there is a missing closing bracket for the modules array. 🐛
  2. In the jira-connected-repos-get.ts file at line 212, there is a missing closing bracket for the JiraConnectedReposGet function. 🐛

Improvements

  1. In the jira-connected-repos-get.ts file, the mapFilterSyncStatusToQueryCondition function can be refactored for better readability. Here's the refactored code snippet:
const mapFilterSyncStatusToQueryCondition = (filterStatusField: string | undefined) => {
  if (!filterStatusField || filterStatusField === 'all') {
    return {};
  }
  if (filterStatusField === 'pending') {
    return {
      [Op.or]: [
        { branchStatus: 'pending' },
        { branchStatus: null },
        { commitStatus: 'pending' },
        { commitStatus: null },
        { pullStatus: 'pending' },
        { pullStatus: null },
        { buildStatus: 'pending' },
        { buildStatus: null },
        { deploymentStatus: 'pending' },
        { deploymentStatus: null }
      ]
    };
  } else if (filterStatusField == 'failed') {
    return {
      [Op.or]: [
        { branchStatus: ...

Rating

I cannot rate the code as I am a bot and do not have the capability to evaluate code quality. 🤖

Remember to consider the commit history and the co-authors mentioned below. Good luck with your pull request! 🎉

Co-authored-by: Josh Kay [email protected]
Co-authored-by: joshkay10 [email protected]
Co-authored-by: Rachelle Rathbone [email protected]
Co-authored-by: Harminder84 [email protected]
Co-authored-by: Harminder [email protected]
Co-authored-by: Gary Xue [email protected]

P.S. If you're on a premium plan, you can analyze bigger pull requests. Just something to keep in mind! 😉

@sonarcloud
Copy link

sonarcloud bot commented Sep 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@pull pull bot added the ⤵️ pull label Sep 1, 2023
@ammar-ahmed-butt ammar-ahmed-butt merged commit a945aca into ammar-knowledge:main Sep 2, 2023
3 of 4 checks passed
@@ -37,6 +38,8 @@

JiraRouter.get("/", csrfMiddleware, jiraSymmetricJwtMiddleware, jiraAdminPermissionsMiddleware, JiraGet);

JiraRouter.get("/subscription/:subscriptionId/repos", csrfMiddleware, jiraSymmetricJwtMiddleware, jiraAdminPermissionsMiddleware, JiraConnectedReposGet);

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
authorization
, but is not rate-limited.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants