Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup the code and 41 support #23

Merged
merged 5 commits into from
Sep 30, 2021
Merged

Cleanup the code and 41 support #23

merged 5 commits into from
Sep 30, 2021

Conversation

jrahmatzadeh
Copy link
Contributor

@jrahmatzadeh jrahmatzadeh commented Sep 22, 2021

Cleanup prefs.js and extension.js

Removed

  • Unnecessary imports.
  • Unnecessary PrefsWidget class.
  • tools.js since it is not needed anymore.
  • Trailing spacing and tab + chars lines.
  • Getting gsettings in global scope that can cause rejection on ego.
  • Connecting signal in init that can cause rejection on ego.

Added

  • Debug mode for logs (will be rejected if you send it with normal log, Before sending for review you need set "debug" to false in metadata.json).
  • jsdoc.
  • resetToggleStatus function to have more organized resetting toggle.
  • Separate minimizeWindows and unminimizeWindows functions to have more readable code.

Changed

  • Settings signal for more accurate and correct changed signal.
  • If statements to more readable statements.

GNOME Shell 41 Support

While the support has been added to the metadata.json you need test it before release it on ego. Should work on 41 but I haven't tested it.

@amivaleo
Copy link
Owner

Thank you dude...

@amivaleo amivaleo merged commit 7a12600 into amivaleo:master Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants