Issue firefox-devtools#3966: Show small values inside tooltip (firefo…

…x-devtools#4218)
amitzur · Oct 5, 2017 · 6eeebb5 · 6eeebb5
1 parent 39f3466
commit 6eeebb5
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/components/Editor/Preview/Popup.js b/src/components/Editor/Preview/Popup.js
@@ -187,6 +187,8 @@ export class Popup extends Component {
     if (
       typeof value == "number" ||
       typeof value == "boolean" ||
+      (typeof value == "string" && value.length < 10) ||
+      (typeof value == "number" && value.toString().length < 10) ||
       value.type == "null" ||
       value.type == "undefined" ||
       value.class === "Function"

diff --git a/src/utils/editor/expression.js b/src/utils/editor/expression.js
@@ -38,14 +38,22 @@ export function updatePreview(
 
   const invalidToken =
     tokenText === "" || tokenText.match(/[(){}\|&%,.;=<>\+-/\*\s]/);
+
   const invalidTarget =
     (target.parentElement &&
       !target.parentElement.closest(".CodeMirror-line")) ||
     cursorPos.top == 0;
+
   const isUpdating = preview && preview.updating;
+
   const inScope = linesInScope && linesInScope.includes(location.line);
 
-  if (invalidTarget || !inScope || isUpdating || invalidToken) {
+  const invaildType =
+    target.className === "cm-string" ||
+    target.className === "cm-number" ||
+    target.className === "cm-atom";
+
+  if (invalidTarget || !inScope || isUpdating || invalidToken || invaildType) {
     return;
   }