Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render a Dialog when a new file is opened and current file is modified #32

Conversation

CriPstian
Copy link

This is in regard with #23
When the new file button is pressed, and the current file is not clean it will prompt the user with a save/don't save/cancel dialog.

  • Upon pressing the save button, the user it requested to specify a path for saving the file.
  • Pressing the Don't save button will create the new file and lose reference to current one
  • Pressing the Cancel button will close the dialog and do not create a new file

@amitmerchant1990
Copy link
Owner

amitmerchant1990 commented Dec 21, 2018

@CriPstian I tested the functionality that you've implemented but I think there's an issue in it. When you make some changes into the existing file and try to create a new file, it's giving the prompt that you've implemented. But instead of saving the existing file, it gives me the dialog to save it once again. And if I cancel that dialog the new file window is opening up, instead of giving me the original state of my previous file.

This is not the intended behaviour. Apart from this, the functionality looks fine. Can you please look into the issue I mentioned above and fix it?

@CriPstian CriPstian force-pushed the bugfix/new-file-prompt-changes-not-saved branch from da15ef8 to 159dac2 Compare December 22, 2018 23:14
@CriPstian CriPstian force-pushed the bugfix/new-file-prompt-changes-not-saved branch from 159dac2 to 74723b8 Compare December 24, 2018 10:01
@CriPstian
Copy link
Author

@amitmerchant1990 Happy New Year!
When you have the time, I updated my PR so you can have a look.
Thanks.

@CriPstian CriPstian closed this Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants