Add more/ Remove button #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpscholten
reviewed
Oct 6, 2021
| <label> | ||
| Max | ||
| </label> | ||
| <input type="number" name="max" value="{get #max bidStep}" class={classes ["form-control", ("is-invalid", isInvalidMax)]}/> |
There was a problem hiding this comment.
To fix the console warnings try this:
-value="{get #max bidStep}"
+value={inputValue (get #max bidStep)}There was a problem hiding this comment.
If I change to value="... I get
The specified value "{inputValue (get #min bidStep)}" cannot be parsed, or is out of range.
Removing the quotes (") results with no errors, however the default value is now set to 0 (instead of remaining blank).
btw, if I manually remove the 0, and try to submit, I'd still get an error:
There was a problem hiding this comment.
Yes the quotes need to be removed :)
Try this:
value={if didChange #max bidStep
then inputValue (get #max bidStep)
else ""
}There was a problem hiding this comment.
Yeah, the if didChange did the trick.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Peek.2021-10-06.13-11.mp4
One thing I've noticed is that on console.log we get those warnings:
I suspect it's related to digitallyinduced/ihp#1099