This repository has been archived by the owner on Mar 6, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems
The loaders of webpack supports
raw
options to decide the input should bebuffer
orstring
.If loaders set
raw
to true as follow:Then, happypack should pass the content of file as buffer to them.
However, happypack currently only pass the content of file as string to each loader
Solutions
Using convertArgs which official utils, loader-runner, does to convert the content of file
Actually, there may be still some problems, for example, the format of
gif
may be broken after using happypack with image-webpack-loader, so the best solution is to introduce loader-runner to handle loadersRelated Issues
#114, #204, #233, #240