Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and fix compiler errors with recent DMD (v2.109.9) #11

Merged
merged 8 commits into from
Jul 12, 2024

Conversation

stonemaster
Copy link

No description provided.

Copy link
Owner

@aminya aminya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the CI as well?

@stonemaster
Copy link
Author

Sure, I am happy to check what's going on with the CI!

What is your opinion on the compiler versions used: should the old versions be replaced by recent LDC/DMD versions? At a first glance there are some random looking build errors but I don't know whether they are related to old compiler versions ..

@aminya
Copy link
Owner

aminya commented Jul 2, 2024

Yes, I am fine dropping support for old compilers as long as we bump the major version

@aminya
Copy link
Owner

aminya commented Jul 3, 2024

Sub flags are deprecated for dmd, they should be removed from the dub file

.github/workflows/CI.yml Outdated Show resolved Hide resolved
.github/workflows/CI.yml Outdated Show resolved Hide resolved
@stonemaster
Copy link
Author

Thanks for the last commits. It seems that two build configurations failed because of "out of memory" :-|

Locally the lint command runs fine for me but outputs the following strange error:

...d-tree-sitter/script/lib/meson.d(0:0)[warn]: Variable  is never modified and could have been declared const or immutable.

.github/workflows/CI.yml Outdated Show resolved Hide resolved
@aminya aminya merged commit 8014f88 into aminya:master Jul 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants