Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix private bucketpolicy #196

Merged
merged 5 commits into from
Mar 30, 2022
Merged

Fix private bucketpolicy #196

merged 5 commits into from
Mar 30, 2022

Conversation

BuJo
Copy link
Collaborator

@BuJo BuJo commented Mar 30, 2022 •
edited by felladrin
Loading

A regression was introduced by #130 making new private buckets visible from outside.

@BuJo BuJo linked an issue Mar 30, 2022 that may be closed by this pull request
Objects are publicly readable when using private bucket ACL #193
Closed
felladrin
felladrin approved these changes Mar 30, 2022
View reviewed changes
Copy link
Collaborator

@felladrin felladrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick resolution for this issue, @BuJo!

@felladrin felladrin merged commit ef47e90 into aminueza:master Mar 30, 2022
@BuJo BuJo deleted the fix_private_bucketpolicy branch March 30, 2022 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felladrin felladrin felladrin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Objects are publicly readable when using private bucket ACL
2 participants
@BuJo @felladrin