Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create 'combined' output dir if it doesn't exist #16

Merged
merged 7 commits into from
Mar 23, 2023

Conversation

cjduffett
Copy link
Contributor

Overview

We typically don't check-in the combined output directory, only the local and managed directories, since combined policies can change dramatically between wonk builds. When running wonk in automated environments like Atlantis, the output dir may not exist at all or may be ephemeral.

I updated wonk to create the combined output dir if it doesn't already exist. I also updated all project dependencies, namely to relay the PyYAML constraint (so downstream dependencies may start using PyYAML 6.0+).

@cjduffett cjduffett requested a review from kstrauser March 23, 2023 20:59
@cjduffett cjduffett marked this pull request as ready for review March 23, 2023 20:59
Copy link

@briankzimmer briankzimmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

Copy link
Collaborator

@kstrauser kstrauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me.

@cjduffett cjduffett merged commit f87cb07 into aminohealth:dev Mar 23, 2023
@cjduffett cjduffett deleted the cduffett/upsert-wonk-dirs branch March 23, 2023 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants