Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for python 3.13 #71

Merged
merged 9 commits into from
Nov 4, 2024
Merged

Add support for python 3.13 #71

merged 9 commits into from
Nov 4, 2024

Conversation

king-phyte
Copy link
Contributor

Other changes:

  • Drop support for python 3.8
  • Update dependencies

@king-phyte
Add support for python 3.13
a5432fe 
Other changes:
- Drop support for python 3.8
- Update dependencies
@king-phyte
Revert upload-artifact to v3
219d374 
upload-artifact v4 is broken for systems using matrix of versions. See actions/upload-artifact#478
@king-phyte
Update dependencies
ac6e728
@king-phyte
Drop support for python 3.8
2a0148f
@king-phyte
Remove unused import
1efdc18
@king-phyte
Fix formatting
a472b50
@king-phyte
Copy link
Contributor Author

king-phyte commented Oct 25, 2024 •
edited
Loading

@aminalaee @trim21 Please take a look at this PR (and maybe squash and merge 😅)

@trim21
Copy link
Contributor

trim21 commented Oct 26, 2024

look good to me, no actually code changes

trim21
trim21 reviewed Oct 26, 2024
View reviewed changes
.github/workflows/ci.yml Outdated
@@ -68,20 +68,20 @@ jobs:
- uses: actions/checkout@v3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should also upgrade this one

@trim21
Copy link
Contributor

trim21 commented Oct 26, 2024 •
edited
Loading

actions/upload-artifact@v4 is not broken for matrix, it just need different name.

for example, use wheels-${{ matrix.job-index }} and use wheels-* with merge-multiple (or another option name, I forget) in download-artifact v4

@king-phyte
Copy link
Contributor Author

for example, use wheels-${{ matrix.job-index }} and use wheels-* with merge-multiple (or another option name, I forget) in download-artifact v4

@trim21 Correct me if I am wrong, but I think you mean strategy.job-index from the docs

@king-phyte
Upgrade upload-artifact to v4
c3dd7bc
@king-phyte
Add job ID to uploaded artifact names
e5c745f 
Using only the job index of strategy as part of the artifact name still causes duplicate names after the first job succeeds, and duplicate names are errors in `actions/upload-artifact@v4`. See https://github.com/actions/download-artifact/blob/main/docs/MIGRATION.md#multiple-uploads-to-the-same-named-artifact
@king-phyte
Copy link
Contributor Author

@trim21 can we get this reviewed and merged?

@trim21
Copy link
Contributor

trim21 commented Oct 27, 2024

@trim21 can we get this reviewed and merged?

I don't have permission to merge PR

@king-phyte
Copy link
Contributor Author

Oh. My bad. Thanks for the review and nudges by the way @trim21
I suppose we have to wait for @aminalaee

@trim21
Copy link
Contributor

trim21 commented Oct 31, 2024 •
edited
Loading

is there a classifiers for Python39+ ？ this package is now a abi3 package and should be able to support all future version of cpython<4

@king-phyte
Copy link
Contributor Author

Not that I know of

aminalaee
aminalaee approved these changes Nov 4, 2024
View reviewed changes
Copy link
Owner

@aminalaee aminalaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks both for the PR

@aminalaee aminalaee merged commit 600c38b into aminalaee:main Nov 4, 2024
21 checks passed
@king-phyte
Copy link
Contributor Author

@aminalaee Thank you. If I may ask, when can we expect the new release. This is currently blocking one of my projects from transitioning to Python 3.13

@trim21
Copy link
Contributor

trim21 commented Nov 4, 2024 •
edited
Loading

I think we should at least solve #69 by merging #70 or remove SafeUUID from pyi before next release

@aminalaee aminalaee mentioned this pull request Nov 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trim21 trim21 trim21 left review comments

@aminalaee aminalaee aminalaee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@king-phyte @trim21 @aminalaee