-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow visualizing layers from yarp ports #2
Conversation
#include <GL/gl.h> | ||
#include <GL/glext.h> | ||
|
||
#if defined(__APPLE__) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: Using ||
for the macro check https://gcc.gnu.org/onlinedocs/gcc-9.2.0/cpp/Defined.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just edited that file bringing back the setup for glfw
that requires the three distinct cases.
With 41299ba I avoid creating an additional window and I paint the background black. |
Added method to add head-fixed quad layer to the OpenXr interface. First working result displaying yarp images on the eyes. Avoid the use of manual flipping. Fixing the aspect ratio according to the input image. Avoid to use callback to read image. Using alpha channel when the input type is RGBA. Added possibility to get layer quaternion and position. Added separate setters for quad position and orientation. Fixed binding of textures. The port is now a shared pointer.
Moved GLFW include where needed. Removed duplicated macro Cleanup before PR.
This PR is now ready to be merged @traversaro @Yeshasvitvs @kouroshD. Let me know if you are ok with that. |
Ok! |
I will review the PR today if it is OK for you. |
Sure, thanks! |
@S-Dafarra is there any configuration file that we should check? Since, in this PR I cannot find any, but in the code we are checking/reading values of the config file and setting the parameters. |
No there are none. Configuration parameters can be passed as command line arguments with the |
So, can you write down here the parameters to pass to yarpdev. |
I usually prefer to add a README when I reach a stable version. Is that ok? If you want, you can try it with
|
yes, thank you. |
Thank you all! Merging |
This PR allows visualizing 2D images on the HMD reading from yarp ports.
In principle, it allows visualizing the robot cameras and to visualize other infos like the virtual robot (also considering the transparencies)
It is based on the
firstVersion
branch and needs #1 to be merged first. This is just to start the review processExample of output
(Notice that the small robot on the bottom has no background)