Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IK NLP: Do not use using namespace iDynTree #1

Conversation

RiccardoGrieco
Copy link
Member

@yeshasvitirupachuri
Copy link
Member

IK NLP: remove using namespace iDynTree

@RiccardoGrieco I see you added iDynTree namespace scope. May be the title of the PR is a bit misleading. please double check it.

@RiccardoGrieco RiccardoGrieco changed the title IK NLP: remove using namespace iDynTree IK NLP: Do not use using namespace iDynTree Nov 23, 2021
@RiccardoGrieco
Copy link
Member Author

IK NLP: remove using namespace iDynTree

@RiccardoGrieco I see you added iDynTree namespace scope. May be the title of the PR is a bit misleading. please double check it.

I changed the name to the one of robotology#861. However, I didn't put the "to fix Eigen 3.4 compatibility" because I think the whole sentence can be misleading too.

Proceeding with the merge.

@RiccardoGrieco RiccardoGrieco merged commit 6fec756 into ami-iit:feature/stack-of-tasks-berdy Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants