Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to Helper method (library version for use with Marlin PR #13498) #14

Merged
merged 16 commits into from
Jan 9, 2020
Merged

Switch to Helper method (library version for use with Marlin PR #13498) #14

merged 16 commits into from
Jan 9, 2020

Conversation

Bob-the-Kuhn
Copy link

@Bob-the-Kuhn Bob-the-Kuhn commented May 18, 2019 •
edited
Loading

This adds L6480 & powerSTEP01 support using the HELPER class method.

These are the files used with Marlin PR #13498 PR #13498

This PR replaces PR #13 (Pointer method update).

@Bob-the-Kuhn Bob-the-Kuhn mentioned this pull request May 18, 2019
Closed
@Bob-the-Kuhn Bob-the-Kuhn reopened this Jan 4, 2020
@Bob-the-Kuhn
Copy link
Author

Bob-the-Kuhn commented Jan 4, 2020 •
edited by thinkyhead
Loading

See MarlinFirmware/Marlin#16452 for the Marlin code that goes with this PR.

@Bob-the-Kuhn Bob-the-Kuhn mentioned this pull request Jan 4, 2020
Merged
@thinkyhead
Copy link
Collaborator

I suppose this should actually get redirected into the dev branch since that's the one we'll be continuing to use for bugfix-2.0.x and dev-2.1.x. I'll cross my fingers and try the "change base" button….

@thinkyhead thinkyhead changed the base branch from master to dev January 9, 2020 07:26
@thinkyhead thinkyhead changed the base branch from dev to master January 9, 2020 07:28
@thinkyhead
Copy link
Collaborator

Oops, well I see that the 2.0.x branch (and releases) are pointing at dev here. So I guess that branch can't be modified any more, or at least we'll have to add a dev tag if the branch goes away.

Meanwhile, this can be merged into a separate branch for testing. I'll clone master now as newdev for use in continuing Marlin development, and merge this PR into that branch.

@thinkyhead thinkyhead changed the base branch from master to newdev January 9, 2020 08:30
@thinkyhead thinkyhead merged commit d6f0b62 into ameyer:newdev Jan 9, 2020
thinkyhead pushed a commit that referenced this pull request Jan 9, 2020
@Bob-the-Kuhn @thinkyhead
Switch to Helper method (#14)
4623a58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bob-the-Kuhn @thinkyhead