Refactor how allocation/deletion works #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| struct CompFloat(f32); | ||
| impl specs::Component for CompFloat { | ||
| // HashMapStorage is better for componets that are met rarely | ||
| type Storage = specs::VecStorage<CompFloat>; |
|
I'm happy with the code. Is it still being updated? Please merge when finished. |
|
@kvark I want to add some more docs and maybe another look over. There are a few places I would like to improve since they are suboptimal (the bitset clear for example). |
ghost
merged commit
|
Warnings: performance of building the entities got affected. Need to have another look at this change. |
kvark
changed the title
ghost
mentioned this pull request
xMAC94x
pushed a commit
to xMAC94x/specs
that referenced
this pull request
Mar 10, 2021
44: Include name of system that was not found in panic message r=torkleyy I have run into this error many times and it's not fun to find the source using `RUST_BACKTRACE`. This should help find the cause of the error quicker and more easily.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Joinover theentities()This removes the
add_list/sub_listin-favour of atomic bit sets. Killing an Entity sets a bit atomically that can be looked up later during the merge. Raising a dead entity is done via an atomic bitset too. This allows systems to iterate over the entities without blocking system that need to create or delete entities.The other big part of this change is that the functionality of the DynamicEntityIter & the EntitiyIter are now in one place. We merge the known alive entity ids, with any raised entities. The
Entitiescan see entities that are created by systems in parallel, which might cause some unpredictable behaviour. But if you are masking with a component (that is locked upstream) it still reliably work.