Dxgi factory is still alive after disposal?

[Gavin-Williams]

Edit: I think the second example below is clearer.

I can't seem to get rid of some live objects. After calling factory6.Dispose() and then reporting live objects. I get the following output:

T: 1 | Application.Ctor
T: 1 | Device3dFactory.CreateDevice | I
T: 1 | Device3dFactory.CreateDevice | O
DXGI WARNING: Live IDXGIFactory at 0x000002F7E4504640, Name: Device3dFactory.factory6, Refcount: 3 [ STATE_CREATION WARNING #0: ]
DXGI WARNING: 	Live IDXGIAdapter at 0x000002F7E6669280, Refcount: 1 [ STATE_CREATION WARNING #0: ]

The code through the first and second call to ReportLiveObjects method is:

 public static Device3d CreateDevice(in DeviceDescriptor descriptor)
        {
            Debug.LogMessage("Device3dFactory.CreateDevice | I");
            ReportLiveObjects();

            DeviceDescriptor = descriptor;
            using IDXGIFactory2 factory = CreateDXGIFactory2<IDXGIFactory2>(descriptor.ValidationMode != ValidationMode.Disabled);
            factory.DebugName = "Device3d.factory";

            IDXGIFactory6 factory6 = factory.QueryInterfaceOrNull<IDXGIFactory6>();
            factory6.DebugName = "Device3dFactory.factory6";

            if (factory6 != null)
            {
                GpuPreference gpuPreference = ToDXGI(descriptor.PowerPreference);

                for (int adapterIndex = 0; factory6!.EnumAdapterByGpuPreference(adapterIndex, gpuPreference, out Adapter).Success; adapterIndex++)
                {
                    AdapterDescription1 desc = Adapter!.Description1;

                    // Don't select the Basic Render Driver adapter.
                    if ((desc.Flags & AdapterFlags.Software) != AdapterFlags.None)
                    {
                        Adapter.Dispose();

                        continue;
                    }

                    if (IsSupportedFeatureLevel(Adapter, Vortice.Direct3D.FeatureLevel.Level_11_1, DeviceCreationFlags.BgraSupport))
                    {
                        break;
                    }
                }

                factory6.Dispose(); // dispose calls release behind the scenes.
                Debug.LogMessage("Device3dFactory.CreateDevice | O");
                ReportLiveObjects();
            }

The report live objects method:

        private static void ReportLiveObjects()
        {
            if (DXGI.DXGIGetDebugInterface1(out IDXGIDebug1 dxgiDebug).Success)
            {
                dxgiDebug!.ReportLiveObjects(DXGI.DebugAll, ReportLiveObjectFlags.Detail | ReportLiveObjectFlags.IgnoreInternal);
                dxgiDebug!.Dispose();
            }
        }

I just don't see how factory6 can still be live.

Can anyone see something wrong, or explain why I don't understand the output?

[Gavin-Williams]

Alright, I've reworked my graphics setup code and I have another example of live factory, this is a function that gets the adapter matching a given descriptor (which doesn't make sense to me, but that's a different issue). Here I create a factory to get the adapter. Then before returning the adapter I dispose the factory. But the DXGI warning implies that there are still 2 live factory references.

        public static IDXGIAdapter1 GetAdapter(in DeviceDescriptor descriptor)
        {
            Debug.LogMessage("[1]----------");
            DirectXTools.ReportLiveDxgiObjects();

            IDXGIFactory2 factory = CreateDXGIFactory2<IDXGIFactory2>(descriptor.ValidationMode != ValidationMode.Disabled);
            factory.DebugName = "DirectXTools.factory";

            factory.EnumAdapters1(0, out IDXGIAdapter1 adapter);
            adapter.DebugName = "DirectXTools.adapter";

            factory.Dispose();

            Debug.LogMessage("[2]----------");
            DirectXTools.ReportLiveDxgiObjects();

            return adapter;
        }

Output:

T: 1 | [1]----------
T: 1 | [2]----------
DXGI WARNING: Live IDXGIFactory at 0x000001DDFA394570, Name: DirectXTools.factory, Refcount: 2 [ STATE_CREATION WARNING #0: ]
DXGI WARNING: 	Live IDXGIAdapter at 0x000001DDFA53CCA0, Name: DirectXTools.adapter, Refcount: 1 [ STATE_CREATION WARNING #0: ]

[amerkoleci]

You need adapter.Dispose() before factory Dispose

[Gavin-Williams]

Well if I compress the creation and dispose cycle it Outputs what I expect.

T: 1 | [A] before creation
T: 1 | [B] after factory creation
DXGI WARNING: Live IDXGIFactory at 0x0000024C66F15E70, Name: DirectXTools.factory, Refcount: 2 [ STATE_CREATION WARNING #0: ]
T: 1 | [C] after get adapter
DXGI WARNING: Live IDXGIFactory at 0x0000024C66F15E70, Name: DirectXTools.factory, Refcount: 3 [ STATE_CREATION WARNING #0: ]
DXGI WARNING: 	Live IDXGIAdapter at 0x0000024C6AD720E0, Name: DirectXTools.adapter, Refcount: 1 [ STATE_CREATION WARNING #0: ]
T: 1 | [D] after dispose

But if I move the dispose calls down to follow the device creation and debug configuration, it's wrong...

T: 1 | [A] before creation
T: 1 | [B] after factory creation
DXGI WARNING: Live IDXGIFactory at 0x000001DD56388880, Name: DirectXTools.factory, Refcount: 2 [ STATE_CREATION WARNING #0: ]
T: 1 | [C] after get adapter
DXGI WARNING: Live IDXGIFactory at 0x000001DD56388880, Name: DirectXTools.factory, Refcount: 3 [ STATE_CREATION WARNING #0: ]
DXGI WARNING: 	Live IDXGIAdapter at 0x000001DD56389050, Name: DirectXTools.adapter, Refcount: 1 [ STATE_CREATION WARNING #0: ]
T: 1 | [D] after dispose
DXGI WARNING: Live IDXGIFactory at 0x000001DD56388880, Name: DirectXTools.factory, Refcount: 2 [ STATE_CREATION WARNING #0: ]
DXGI WARNING: 	Live IDXGIAdapter at 0x000001DD56389050, Name: DirectXTools.adapter, Refcount: 1 [ STATE_CREATION WARNING #0: ]
D3D11 WARNING: Live ID3D11Device at 0x000001DD56BDDAA0, Name: DirectXTools.device, Refcount: 3 [ STATE_CREATION WARNING #441: LIVE_DEVICE]
D3D11 WARNING: 	Live ID3D11Context at 0x000001DD56BDFAE0, Name: DirectXTools.context, Refcount: 1, IntRef: 1 [ STATE_CREATION WARNING #2097226: LIVE_CONTEXT]

[Gavin-Williams]

Is it OK to destroy these (factory and adapter) after using them or do we have to keep them alive for the lifetime of the application?

[Gavin-Williams]

I've moved adapter and factory references out to my device class and dispose them when I dispose the device. I've gotten the output down to something that looks acceptable. Though I don't know what the ref count = 1 means. I've had ref count = 0 at times, and there 'seems' to be no live objects here.

T: 1 | Application | Shutting down...
T: 1 | Device3d.Dispose | Ref count = 1
The program '[2800] DemoBasics.exe' has exited with code 0 (0x0).

[Gavin-Williams]

It's 2 steps forward, 2 steps back. There is no lasting solution to finding live objects. This comment on gamedev.net suggests that I can get more information..

First: rather than device.As(&debug), try device->QueryInterface(IID_PPV_ARGS(&debug)) to report actual object types, rather than "Live Object." That is, you'll get descriptions in terms of "ID3D11Context" rather than "Live Object,"

This implies that there is some way to get the name of objects, instead of Live Object. And sometimes I get postive ref counts but no debug output.

T: 1 | -------------------------
T: 1 | Report live D3d11 objects
T: 1 | -------------------------
T: 1 | Device3d.Dispose | Ref count = 3
T: 1 | -------------------------
T: 1 | Report live Dxgi objects
T: 1 | -------------------------
DXGI WARNING: Live IDXGIFactory at 0x0000028A68712920, Name: DirectXTools.adapter, Refcount: 2 [ STATE_CREATION WARNING #0: ]
DXGI WARNING: 	Live IDXGIAdapter at 0x0000028A6C527060, Refcount: 1 [ STATE_CREATION WARNING #0: ]
DXGI WARNING: Live Producer at 0x0000028A687129B8, Refcount: 2. [ STATE_CREATION WARNING #0: ]
DXGI WARNING: 	Live Object at 0x0000028A6C527060, Refcount: 1. [ STATE_CREATION WARNING #0: ]
DXGI WARNING: Live                         Object :      1 [ STATE_CREATION WARNING #0: ]
The program '[25744] DemoBasics.exe' has exited with code 0 (0x0).

[amerkoleci]

It's impossible for me to FIX those issues if I cannot have repro test or some code to debug.

[Gavin-Williams]

ok, I guess I've just been assuming its my fault. And hoping someone would say 'you have to do this' I'm about to ask again on the Dx discord. But I can also put a minimal project together over the weekend for you.

[Gavin-Williams]

This is the code that destroys things in order and gives the expected nil output.

#if DEBUG
        ReportLiveD3d11Objects(DxDevice);
#endif
        DxDevice.Dispose();
        DxFactory.Release();
        DxAdapter.Release();
        DxAdapter.Dispose();
#if DEBUG
        ReportLiveDxgiObjects();