chore(deps): bump rimraf from 2.6.2 to 5.0.10 #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
src/diff-snapshot.js
Outdated
| @@ -271,10 +271,10 @@ function diffImageToSnapshot(options) { | |||
| result = { added: true }; | |||
| } else { | |||
| const receivedSnapshotPath = path.join(receivedDir, `${snapshotIdentifier}${receivedPostfix}.png`); | |||
| rimraf.sync(receivedSnapshotPath); | |||
| rimrafSync(receivedSnapshotPath, { glob: true }); | |||
There was a problem hiding this comment.
Is glob: true required here?
There was a problem hiding this comment.
The test cases pass without glob: true here.
Without it in integration.spec.js an error is thrown stating "Illegal characters in path.".
Since the path came from options then I´m not sure if it can become a problem without setting glob to true so I added it here as well. If you think this assumption is wrong then I have no problem removing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #355
Motivation and Context
How Has This Been Tested?
Types of Changes
Checklist:
What is the Impact to Developers Using Jest-Image-Snapshot?