chore(packages): Upgrade from pixelmatch 4.x to 5.x, and pngjs to 3.4 #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anescobar1991
requested changes
Mar 15, 2020
ReDrUm
force-pushed
the
chore/upgrade-pixelmatch
branch
2 times, most recently
from
9030c25
to
4f44fe4
Compare
ReDrUm
force-pushed
the
chore/upgrade-pixelmatch
branch
from
4f44fe4
to
406f763
Compare
anescobar1991
approved these changes
Mar 19, 2020
anescobar1991
approved these changes
Mar 22, 2020
oneamexbot
added a commit
that referenced
this pull request
Mar 24, 2020
# [3.0.0](v2.12.0...v3.0.0) (2020-03-24) ### Bug Fixes * **diff:** small default maxBuffer ([df713f6](df713f6)) * **diff-snapshot:** dumpDiffToConsole base64 string output ([#183](#183)) ([f73079f](f73079f)) ### chore * **packages:** updating jest to 25.1 for perf improvements ([#170](#170)) ([eb3dfa6](eb3dfa6)) * **packages:** upgrade from pixelmatch 4.x to 5.x, and pngjs to 3.4 ([#186](#186)) ([1edc9a3](1edc9a3)) * **travis:** remove node 6 from travis config ([ce2b757](ce2b757)) ### Features * **diff:** increase the maxBuffer to 10MB for the diff process ([#167](#167)) ([0927826](0927826)) ### BREAKING CHANGES * **packages:** pixelmatch is being major version bumped and so image diffs may be difference * **packages:** Node min version is now 8 * **travis:** drop support for node 6
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
I don't think this should have been released without first addressing the now-redundant identicality check mentioned in #152, as changed snapshots will now be doing unnecessary work, potentially hurting performance. |
|
Yeah I think you’re right... let me open a PR to fix that today. |
|
Opened up #191 @noinkling! |
goverdhan07
pushed a commit
to goverdhan07/jest-image-snapshot
that referenced
this pull request
Jul 23, 2023
…americanexpress#186) BREAKING CHANGE: pixelmatch is being major version bumped and so image diffs may be difference
goverdhan07
pushed a commit
to goverdhan07/jest-image-snapshot
that referenced
this pull request
Jul 23, 2023
# [3.0.0](americanexpress/jest-image-snapshot@v2.12.0...v3.0.0) (2020-03-24) ### Bug Fixes * **diff:** small default maxBuffer ([df713f6](americanexpress@df713f6)) * **diff-snapshot:** dumpDiffToConsole base64 string output ([americanexpress#183](americanexpress#183)) ([f73079f](americanexpress@f73079f)) ### chore * **packages:** updating jest to 25.1 for perf improvements ([americanexpress#170](americanexpress#170)) ([eb3dfa6](americanexpress@eb3dfa6)) * **packages:** upgrade from pixelmatch 4.x to 5.x, and pngjs to 3.4 ([americanexpress#186](americanexpress#186)) ([1edc9a3](americanexpress@1edc9a3)) * **travis:** remove node 6 from travis config ([ce2b757](americanexpress@ce2b757)) ### Features * **diff:** increase the maxBuffer to 10MB for the diff process ([americanexpress#167](americanexpress#167)) ([0927826](americanexpress@0927826)) ### BREAKING CHANGES * **packages:** pixelmatch is being major version bumped and so image diffs may be difference * **packages:** Node min version is now 8 * **travis:** drop support for node 6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades pixelmatch & pngjs to latest releases.
https://github.com/mapbox/pixelmatch/releases/tag/v5.0.0
Noteworthy changes from the pixelmatch release notes: