Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase the maxBuffer to 10MB for the diff process #167

Merged
merged 3 commits into from
Feb 8, 2020
Merged

Increase the maxBuffer to 10MB for the diff process #167

merged 3 commits into from
Feb 8, 2020

Commits on Feb 1, 2020

  1. test(diff): Add regression test for large images.

    @Gaelan
    Gaelan committed Feb 1, 2020
    Configuration menu
    Copy the full SHA
    27fcd0b View commit details
    Browse the repository at this point in the history

  2. fix(diff): small default maxBuffer 

    By default, Node's spawnSync has a maxBuffer of 1 MB. This bumps it up
to 10 MB, which should reduce the chance of diffs on large images
failing.
    @Gaelan
    Gaelan committed Feb 1, 2020
    Configuration menu
    Copy the full SHA
    df713f6 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2020

  1. Merge branch 'master' into max-buffer

    @anescobar1991
    anescobar1991 authored Feb 8, 2020
    Configuration menu
    Copy the full SHA
    826ea3a View commit details
    Browse the repository at this point in the history