Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

feat(compose): allow modules to abort the composeModules #137

Merged
merged 2 commits into from
Mar 3, 2023

Conversation

10xLaCroixDrinker
Copy link
Member

Description

With this change, modules can add the property abortComposeModules to an error thrown by its loadModuleData function that will abort module composition.

Motivation and Context

In One App, it is desirable to, within a loadModuleData function, abort module composition and redirect the end user.

How Has This Been Tested?

Unit tests

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • My changes are in sync with the code style of this project.
  • There aren't any other open Pull Requests for the same issue/update.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • This change impacts caching for client browsers.
  • This change adds additional environment variable requirements for Holocron users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using Holocron?

This will enable a performance improvement in One App in instances that loading module data results in a decision to redirect the end user.

code-forger
code-forger previously approved these changes Mar 1, 2023
@10xLaCroixDrinker 10xLaCroixDrinker requested a review from a team March 1, 2023 17:19
@10xLaCroixDrinker 10xLaCroixDrinker requested a review from a team March 2, 2023 15:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants