This repository has been archived by the owner on May 15, 2024. It is now read-only.
feat(compose): allow modules to abort the composeModules #137
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this change, modules can add the property
abortComposeModules
to an error thrown by itsloadModuleData
function that will abort module composition.Motivation and Context
In One App, it is desirable to, within a
loadModuleData
function, abort module composition and redirect the end user.How Has This Been Tested?
Unit tests
Types of Changes
Checklist:
What is the Impact to Developers Using Holocron?
This will enable a performance improvement in One App in instances that loading module data results in a decision to redirect the end user.