Skip to content
This repository has been archived by the owner on Dec 10, 2020. It is now read-only.

merge the latest state from upstream #18

Merged
merged 1,062 commits into from
Sep 29, 2017
Merged

merge the latest state from upstream #18

merged 1,062 commits into from
Sep 29, 2017

Conversation

dirk-thomas
Copy link

Pulling in over a year of bug fixes and improvements.

mihai-unity and others added 30 commits May 6, 2017 11:05
…d/make-version

Fix failure of retrieving git hash from a hg-git enabled repository
Fixed work of mod_sort_oc_properties with sp_after_comma
Code appears first time in space.cpp:1039
Removes tests 30310 and 30311 as the new options are activated or the
used example code. The option 'sp_word_brace' is most likely now
obsolete in C++ code but it might be used in other languages.
Deletions and reordering only, no real changes.
indent_ctor_init and indent_ctor_init_leading should apply only to
member initialization lists in constructor as their name suggests,
not to base classes list.
Add options for unnamed temporary direct-list-initializations
Split the logic into two separate 'if' commands (for either a base
classes list or a member initialization list) rather than existing
nested conditions.
@clalancette
Copy link

I'm just doing skimming of the various PRs here to make sure there is nothing obviously wrong, and approving the ones I can. It would be good to see the green CI job.

@dirk-thomas
Copy link
Author

And here are the links to finally finished CI builds:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Ready for review.

@dirk-thomas dirk-thomas added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Sep 29, 2017
Copy link

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not going to review all of the changes to uncrustify itself. The update looks OK, and with a green CI, I'm fine with the updates.

@dirk-thomas dirk-thomas merged commit fa11384 into master Sep 29, 2017
@dirk-thomas dirk-thomas deleted the uncrustify_master branch September 29, 2017 18:12
@dirk-thomas dirk-thomas removed the in review Waiting for review (Kanban column) label Sep 29, 2017
@dirk-thomas
Copy link
Author

And as a follow up the newly referenced PRs remove plenty of INDENT-OFF usage where it isn't necessary anymore or was easy to make the code comply:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Please review the newly referenced PR.

@mikaelarguedas
Copy link

all referenced changes look good to me once ci comes back green

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.