Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare dependencies on expected flake8 plugins. #420

Closed
wants to merge 1 commit into from

Conversation

nuclearsandwich
Copy link
Contributor

These flake8 plugins have been in the from-source setup instructions for ROS 2 a long time. For Ubuntu 22.04 we finally got all of them packaged so we can start removing pip packages from our installation requirements.

I think this change should be back-portable to Humble but it can't go back to Focal because not all of these packages are available there.

This PR requires ros/rosdistro#35197

These flake8 plugins have been in the from-source setup instructions for
ROS 2 a long time. For Ubuntu 22.04 we finally got all of them packaged
so we can start removing pip packages from our installation
requirements.

I think this change should be back-portable to Humble but it can't go
back to Focal because not all of these packages are available there.

Signed-off-by: Steven! Ragnarök <[email protected]>
@nuclearsandwich
Copy link
Contributor Author

@ros-pull-request-builder retest this please

@vonZeppelin
Copy link

Nice, it'll simplify CI setups! Would be great to have as part of the upcoming release – any reasons to delay the merge?

@clalancette
Copy link
Contributor

So we partially did this in #454, so closing this out as a duplicate.

@clalancette clalancette closed this May 1, 2024
@clalancette clalancette deleted the flake8-deps branch May 1, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants