-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Escape backslashes #144
Escape backslashes #144
Conversation
Debug CI; these warnings no longer exist there: https://ci.ros2.org/job/ci_windows/7142/ |
Both changed files are imported versions of upstream projects. Please file PRs against upstream first and once those have been accepted we can pull their latest version into this repo. |
I've opened richq/cmake-lint#36 and google/styleguide#455 That being said, I won't hold my breath for either them to be merged. There have been no accepted changes to upstream cmake-lint since 2017, and the author has said he isn't really interested in it anymore: https://github.com/richq/cmake-lint/issues/29#issuecomment-431682169 The Google styleguide is slightly more active, but after 4 years they still haven't merged the python3 support patch that we are currently relying on: google/styleguide#47 |
Please revert the unrelated whitespace changes from this PR. Then I think we can merge this without squashing. 👍 |
This gets rid of DeprecationWarning on Windows. Signed-off-by: Chris Lalancette <[email protected]>
This fixes DeprecationWarning on Windows. Signed-off-by: Chris Lalancette <[email protected]>
3b2a1ec
to
ac2470d
Compare
Rebased and done. |
CI was done as part of ros2/ci#301, and was successful, so I'll merge this. |
When running on Windows Debug (where all warnings are printed), the backslashes in these strings/comments were causing warnings like:
In cpplint.py, escape the backslashes properly (since these are triple-quoted strings). In cmakelint.py, make the strings raw.