audiveris parsing warnings

CHANGELOG.md

@@ -4,11 +4,19 @@
 
 ### Added
 
-- Audiveris parsing errors now displayed in stage progress?
+- Audiveris parsing warnings now reported on score view
 
 ### Fixed
 
 - "Open In Noteflight" fixed and works without local server
+- Some time signatures were accidentally cut off and failed parsing
+
+### Updated
+
+- Updated most application dependencies to latest (exceptions listed):
+  - `electron` is `11.x.x`, instead of 12
+  - `webpack` is still `4.x.x`, instead of 5
+- Internal code changes to make `Log` component a bit nicer
 
 ## 0.8.0 (2021-05-14)
 

src/common/constants.js

@@ -8,6 +8,9 @@ export const Colors = {
   LightGrey: '#bbb',
   Grey: '#777',
   Charcoal: '#333',
+  Red: '#f00',
+  Yelow: '#ff0',
+  Orange: '#ff7f00',
 };
 
 export const tmpPath = join(remote.app.getPath('userData'), 'tmp');

src/main/index.js

@@ -13,7 +13,7 @@ let mainWindow;
 function createMainWindow() {
   const window = new BrowserWindow({
     webPreferences: { nodeIntegration: true, webviewTag: true, webSecurity: false, enableRemoteModule: true },
-    ...(isDevelopment ? { width: 800, height: 1000 } : { width: 1200, height: 900 }),
+    ...(isDevelopment ? { width: 1200, height: 1000 } : { width: 1200, height: 900 }),
     title: isDevelopment ? undefined : `${app.getName()} (${app.getVersion()})`,
   });
 

src/renderer/Log.jsx

@@ -16,6 +16,12 @@ export const error = (item) => {
   console.error(item);
 };
 
+export const getLog = () => logValues;
+
+export const clearLog = () => {
+  logValues = [];
+};
+
 const errorText = style({
   color: 'red',
 });

src/renderer/Score.jsx

@@ -1,15 +1,16 @@
 import axios from 'axios';
 import { remote } from 'electron';
 import { copyFileSync, readFileSync, writeFileSync } from 'fs';
-import { basename, join, relative } from 'path';
+import { basename, join } from 'path';
 import React, { useEffect, useState } from 'react';
-import { Code, FileText, Image } from 'react-feather';
+import { AlertCircle, Code, FileText, Image } from 'react-feather';
 import { cssRule } from 'typestyle';
 
-import { isDevelopment } from '../common/constants';
+import { Colors, isDevelopment } from '../common/constants';
 import NFClient from '../common/nfclient';
 import { imageDir } from '../common/stages/images';
 import { getTitle } from '../common/util';
+import { getLog, log, logValues } from './Log';
 
 cssRule('#sheetMusic', {
   border: '1px solid #aaa !important',
@@ -57,6 +58,11 @@ export const Score = (props) => {
 
   const margin = 10;
 
+  let foundErrors = 0;
+  getLog().forEach((l) => {
+    if (l.value.indexOf('Exception:') !== -1) foundErrors++;
+  });
+
   return (
     <div style={{ marginTop: 50, width: '100%', height: '100%', display: 'flex', flexDirection: 'column', alignItems: 'center' }}>
       <div style={{ display: 'flex', alignItems: 'center', justifyContent: 'center', marginBottom: 20 }}>
@@ -141,6 +147,11 @@ export const Score = (props) => {
         </button>
       </div>
       <div id="sheetMusic" />
+      {foundErrors > 0 && (
+        <div style={{ display: 'flex', alignItems: 'center', marginTop: margin * 2, fontSize: 18 }}>
+          <AlertCircle color={Colors.Orange} style={{ marginRight: margin }} /> Audiveris Parsing Errors Occured ({foundErrors})
+        </div>
+      )}
     </div>
   );
 };

src/renderer/Status.jsx

@@ -6,7 +6,7 @@ import { Colors, isDevelopment, tmpPath } from '../common/constants';
 import { runStages, Stage } from '../common/stages/stages';
 
 import { Score } from './Score';
-import { Log } from './Log';
+import { clearLog, Log } from './Log';
 import { remote } from 'electron';
 import rimraf from 'rimraf';
 
@@ -43,6 +43,7 @@ export const Status = (props) => {
       <button
         disabled={stage !== Stage.Complete && !error}
         onClick={() => {
+          clearLog();
           const current = remote.getCurrentWindow();
           if (current) current.reload();
         }}
@@ -87,7 +88,7 @@ export const Status = (props) => {
                   >
                     {stage === Stage[s] &&
                       (error ? (
-                        <AlertTriangle style={{ color: 'red' }} />
+                        <AlertTriangle style={{ color: Colors.Red }} />
                       ) : (
                         <SpinnerCircularFixed size={22} thickness={200} color={Colors.Green} secondaryColor={Colors.LightGrey} />
                       ))}
@@ -111,6 +112,7 @@ export const Status = (props) => {
             message: 'Are you sure you want to clear temp cache?',
           });
           if (option === 1) {
+            clearLog();
             rimraf.sync(tmpPath);
             const current = remote.getCurrentWindow();
             if (current) current.reload();