Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for capturing 'yati' positions in a metre. #97

Closed
MSSRPRAD opened this issue Jan 1, 2024 · 1 comment · Fixed by #98
Closed

Add support for capturing 'yati' positions in a metre. #97

MSSRPRAD opened this issue Jan 1, 2024 · 1 comment · Fixed by #98
Labels
chandas enhancement New feature or request good first issue Good for newcomers

Comments

@MSSRPRAD
Copy link
Contributor

MSSRPRAD commented Jan 1, 2024

Currently we don't capture this information neither in our data, data structure nor in the code.

Either we can further break down the scheme from a Vec<Vec<>> to a Vec<Vec<Vec<>>> or we can store it as seperate offsets.

@akprasad
Copy link
Contributor

akprasad commented Jan 1, 2024

I updated meters.tsv to store yati as the | character. But, it's true that yati is not modeled or used anywhere.

Storing it as an offset seems like the right approach (good insight!). Maybe instead of:

weights: Vec<Vec<PatternWeight>>

we can have:

padas: Vec<Pada>

struct Pada {
  weights: Vec<PatternWeight>,
  yati: Vec<usize>
}

(As an aside -- I know PatternWeight is clunky. I'm waiting for the program to mature more before deciding what to do with it.)

@akprasad akprasad added enhancement New feature or request good first issue Good for newcomers chandas labels Jan 1, 2024
MSSRPRAD added a commit to MSSRPRAD/vidyut that referenced this issue Jan 1, 2024
Should resolve ambuda-org#97

1. Added pAdAnta yati in the meters.tsv data
2. The yati information is stored in each pada as offset numbers according to how suggested by @akprasad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chandas enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants