-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update Babel package #486
update Babel package #486
Conversation
@akprasad , python unit tests are failing. You probably noticed it. I don't think this PR broke them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, will approve once the tests pass
It did, see the logs:
I'll take a look. |
@kvchitrapu reverting changes to |
@kvchitrapu I updated the PR so tests pass, but docker fails further in:
|
@akprasad Python 3.10 dependencies have to stabilized. Reverting changes to
Exception:
Searching for a solution. |
Oh, I think my changes to |
All set. We need to change the Babel instantiation in init.py. The unit tests were working on my laptop, but they were not working in GitHub Actions, as the Ubuntu image is still pulling Flask-Babel v2.x. I forgot to update the requirements.txt file. GitHub Actions should now pull v3.0.1, and the unit tests should succeed. |
@akprasad My bad. I should have dug a little deeper on the unit tests failing in GH actions. All good now. Review and merge when you get a chance. |
Thanks! Looks like the PR history has been mixed with some other work, as I see Edit: I'll fix this then merge it in. |
Upgrade the Babel package to version ^2.12 in response to the Python version upgrade. Fixes #483