Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Ruff for Python linting #481

Merged
merged 9 commits into from
Apr 1, 2023
Merged

Switch to Ruff for Python linting #481

merged 9 commits into from
Apr 1, 2023

Conversation

akprasad
Copy link
Contributor

Ruff is a new all-in-one Python linter that combines several previous tools and implements them more quickly. This PR switches to Ruff and cleans up various parts of the code that Ruff has flagged.

@akprasad akprasad requested a review from kvchitrapu March 30, 2023 04:20
@kvchitrapu
Copy link
Collaborator

Thanks. I'll look into it.

@akprasad
Copy link
Contributor Author

akprasad commented Apr 1, 2023

@kvchitrapu I'm seeing a breakage in building the external PR image. I don't know how to resolve this and it's blocking this PR and future work, so I'm landing for now and filed #483 to track.

@akprasad akprasad merged commit d9f32ae into main Apr 1, 2023
@akprasad akprasad deleted the ruff branch April 1, 2023 02:34
@kvchitrapu
Copy link
Collaborator

kvchitrapu commented Apr 1, 2023

Looks like pybabel was removed? Was it intentional?

https://github.com/ambuda-org/ambuda/actions/runs/4580826443/jobs/8089886305#step:4:1170

@akprasad
Copy link
Contributor Author

akprasad commented Apr 1, 2023

right, but how? I don't see how this PR does it. Note that the pybabel command comes from the Babel dependency, which still exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants