Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor initialization #370

Closed
wants to merge 7 commits into from
Closed

Refactor initialization #370

wants to merge 7 commits into from

Commits on Oct 4, 2019

  1. Refactor initialization to remove need for set_attributes 

    Don't make columns nilable by default anymore
No longer include *::Serializable by default
    @Blacksmoke16
    Blacksmoke16 committed Oct 4, 2019
    Configuration menu
    Copy the full SHA
    1053ad4 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2019

  1. Simplify initialize method 

    Use column_names when initializing from result_set
Use property! for not nilable columns
Add converter for bool type (for Sqlite)
    @Blacksmoke16
    Blacksmoke16 committed Oct 5, 2019
    Configuration menu
    Copy the full SHA
    b4ea976 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2019

  1. Implement update functionality 

    Simplify initialization again
    @Blacksmoke16
    Blacksmoke16 committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    d3bf8ee View commit details
    Browse the repository at this point in the history

  2. Some cleanup

    @Blacksmoke16
    Blacksmoke16 committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    104df0b View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2019

  1. Remove default initializer

    @Blacksmoke16
    Blacksmoke16 committed Oct 13, 2019
    Configuration menu
    Copy the full SHA
    c882c38 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2019

  1. Merge remote-tracking branch 'upstream/master' into refactor-initiali… 

    …zation
    @Blacksmoke16
    Blacksmoke16 committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    8e02ddf View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2019

  1. Use getter! for PK 

    Require PK type be not nilable
Add specs to make sure internal ivars are not included in .to_json/yaml
    @Blacksmoke16
    Blacksmoke16 committed Oct 26, 2019
    Configuration menu
    Copy the full SHA
    bae4526 View commit details
    Browse the repository at this point in the history