-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added query macro, tests, and docs #215
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
require "../../spec_helper" | ||
|
||
{% for adapter in GraniteExample::ADAPTERS %} | ||
module {{adapter.capitalize.id}} | ||
describe "{{ adapter.id }} custom select" do | ||
it "generates custom SQL with the query macro" do | ||
ArticleViewModel.select.should eq "SELECT articles.id, articles.articlebody, comments.commentbody FROM articles JOIN comments ON comments.articleid = articles.id" | ||
end | ||
|
||
it "uses custom SQL to populate a view model - #all" do | ||
first = Article.new.tap do |model| | ||
model.articlebody = "The Article Body" | ||
model.save | ||
end | ||
|
||
second = Comment.new.tap do |model| | ||
model.commentbody = "The Comment Body" | ||
model.articleid = first.id | ||
model.save | ||
end | ||
|
||
viewmodel = ArticleViewModel.all | ||
viewmodel.first.articlebody.should eq "The Article Body" | ||
viewmodel.first.commentbody.should eq "The Comment Body" | ||
end | ||
|
||
# TODO: `find` on this ViewModel fails because "id" is ambiguous in a complex SELECT. | ||
|
||
# it "uses custom SQL to populate a view model - #find" do | ||
# first = Article.new.tap do |model| | ||
# model.articlebody = "The Article Body" | ||
# model.save | ||
# end | ||
|
||
# second = Comment.new.tap do |model| | ||
# model.commentbody = "The Comment Body" | ||
# model.articleid = first.id | ||
# model.save | ||
# end | ||
|
||
# viewmodel = ArticleViewModel.find!(first.id) | ||
# viewmodel.articlebody.should eq "The Article Body" | ||
# viewmodel.commentbody.should eq "The Comment Body" | ||
# end | ||
end | ||
end | ||
{% end %} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
module Granite::Select | ||
struct Container | ||
property custom : String? | ||
getter table_name, fields | ||
|
||
def initialize(@custom = nil, @table_name = "", @fields = [] of String) | ||
end | ||
end | ||
|
||
macro query(text) | ||
@@select.custom = {{text.strip}} | ||
|
||
def self.select | ||
@@select.custom | ||
end | ||
end | ||
|
||
macro __process_select | ||
@@select = Container.new(table_name: @@table_name, fields: fields) | ||
end | ||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be called a fieldset?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not so much a set of fields as it is a (loose) container for the query (or SELECT) statement.
Granite::Query
is used in your new query builder, so I tried to capture this as simply as possible. I don't loveGranite::Select::Container
though. Open to ideas.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure
Container
is a little vague, but is it going to show up in an Amber devs code? If not, I don't think it's important to be 100% on target for merging this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. No, the only dev interface is the
query
macro, so not a big deal here.