Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crystal next support #358

Closed
wants to merge 2 commits into from
Closed

Crystal next support #358

wants to merge 2 commits into from

Conversation

veelenga
Copy link
Contributor

@veelenga veelenga commented Nov 4, 2017

@marksiemers
Copy link
Contributor

Right now, Crystal 0.24.0 is not going to be a stable/official release. Waiting for 0.24.1

@marksiemers
Copy link
Contributor

Will reopen after repo cleaning. I have a local copy of this branch, and it still exists in @veelenga 's fork.

@veelenga
Copy link
Contributor Author

veelenga commented Nov 17, 2017

PRs are actually designed to prevent you losing the data locally. Don't see any reason to close it. But anyway if Crystal 0.24 is not going to be stable, better to prepare new PR for future release ;)

@veelenga veelenga deleted the feat/crystal-0.24 branch November 17, 2017 13:24
@marksiemers
Copy link
Contributor

@veelenga - We were attempting to get the total repo size down (from about 8MB) - part of that process meant closing all PRs and deleting all branches.

It didn't quite work - git history on github is a stubborn thing (which is a feature I suppose)

@faustinoaq
Copy link
Contributor

faustinoaq commented Nov 27, 2017

@amberframework/contributors @veelenga Can we reopen it?

For some reason now arch linux is using crystal 0.24.0 on community repo and now I'm getting this error:

Error in src/ruby2crystal.cr:1: while requiring "../config/*"

require "../config/*"
^

in config/application.cr:1: while requiring "amber"

require "amber"
^

in lib/amber/src/amber.cr:5: while requiring "secure_random": can't find file 'secure_random' relative to '/home/main/Projects/ruby2crystal/lib/amber/src'

require "secure_random"

Well, At least I know how to fix it temporally 😅

@faustinoaq
Copy link
Contributor

@veelenga Can we reopen this? Looks like crystal v0.24.1 will be released very soon crystal-lang/crystal#5358 (comment)

@veelenga
Copy link
Contributor Author

veelenga commented Dec 12, 2017

@faustinoaq
Sorry, i can't. Seems like i removed a fork or a branch. Ping me and i will issue new PR for 0.24.1 once it becomes available. Leastwise the change is visible above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants